fix: review fixes

Author: astandrik

src/containers/Operations/Operations.tsx

@@ -63,7 +63,7 @@ export function Operations({database}: OperationsProps) {
                     <ResizeableDataTable
                         columns={getColumns()}
                         data={filteredOperations}
-                        emptyDataMessage={i18n('operations.noData')}
+                        emptyDataMessage={i18n('title_empty')}
                     />
                 ) : null}
             </TableWithControlsLayout.Table>

src/containers/Operations/OperationsControls.tsx

@@ -34,7 +34,7 @@ export function OperationsControls({
             <Search
                 value={searchValue}
                 onChange={handleSearchChange}
-                placeholder={i18n('controls.searchPlaceholder')}
+                placeholder={i18n('pleaceholder_search')}
                 className={b('search')}
             />
             <Select
@@ -43,7 +43,7 @@ export function OperationsControls({
                 onUpdate={(value) => handleKindChange(value[0] as OperationKind)}
             />
             <EntitiesCount
-                label={i18n('label.operations')}
+                label={i18n('label_operations')}
                 loading={entitiesLoading}
                 total={entitiesCountTotal}
                 current={entitiesCountCurrent}

src/containers/Operations/columns.tsx

@@ -100,7 +100,7 @@ export function getColumns(): DataTableColumn<TOperation>[] {
 
                 return row.end_time
                     ? durationFormatted
-                    : i18n('duration.ongoing', {value: durationFormatted});
+                    : i18n('label_duration-ongoing', {value: durationFormatted});
             },
             sortAccessor: (row) => {
                 if (!row.create_time) {

src/containers/Operations/constants.ts

@@ -14,12 +14,12 @@ export const COLUMNS_NAMES = {
 } as const;
 
 export const COLUMNS_TITLES = {
-    [COLUMNS_NAMES.ID]: i18n('column.operationId'),
-    [COLUMNS_NAMES.STATUS]: i18n('column.status'),
-    [COLUMNS_NAMES.CREATED_BY]: i18n('column.createdBy'),
-    [COLUMNS_NAMES.CREATE_TIME]: i18n('column.createTime'),
-    [COLUMNS_NAMES.END_TIME]: i18n('column.endTime'),
-    [COLUMNS_NAMES.DURATION]: i18n('column.duration'),
+    [COLUMNS_NAMES.ID]: i18n('column_operationId'),
+    [COLUMNS_NAMES.STATUS]: i18n('column_status'),
+    [COLUMNS_NAMES.CREATED_BY]: i18n('column_createdBy'),
+    [COLUMNS_NAMES.CREATE_TIME]: i18n('column_createTime'),
+    [COLUMNS_NAMES.END_TIME]: i18n('column_endTime'),
+    [COLUMNS_NAMES.DURATION]: i18n('column_duration'),
 } as const;
 
 export const BASE_COLUMNS = [
@@ -32,7 +32,7 @@ export const BASE_COLUMNS = [
 ];
 
 export const OPERATION_KINDS: {value: OperationKind; content: string}[] = [
-    {value: 'export', content: i18n('kind.export')},
-    {value: 'ss/backgrounds', content: i18n('kind.ssBackgrounds')},
-    {value: 'buildindex', content: i18n('kind.buildIndex')},
+    {value: 'export', content: i18n('kind_export')},
+    {value: 'ss/backgrounds', content: i18n('kind_ssBackgrounds')},
+    {value: 'buildindex', content: i18n('kind_buildIndex')},
 ];

src/containers/Operations/i18n/en.json

@@ -1,41 +1,17 @@
 {
-  "label.operations": "Operations",
-  "operations.noData": "No operations data",
-  "dialog.cancel.header": "Cancel operation",
-  "dialog.cancel.text": "The operation will be cancelled. Do you want to proceed?",
-  "controls.cancelNotAllowed": "You don't have enough rights to cancel this operation",
-  "controls.searchPlaceholder": "Search operations",
-  "controls.kindPlaceholder": "Select operation kind",
-  "page.title": "Operations",
-  "kind.ssBackgrounds": "SS/Backgrounds",
-  "kind.export": "Export",
-  "kind.buildIndex": "Build Index",
-  "status.success": "Success",
-  "status.badRequest": "Bad Request",
-  "status.unauthorized": "Unauthorized",
-  "status.internalError": "Internal Error",
-  "status.aborted": "Aborted",
-  "status.unavailable": "Unavailable",
-  "status.overloaded": "Overloaded",
-  "status.schemeError": "Scheme Error",
-  "status.genericError": "Generic Error",
-  "status.timeout": "Timeout",
-  "status.badSession": "Bad Session",
-  "status.preconditionFailed": "Precondition Failed",
-  "status.alreadyExists": "Already Exists",
-  "status.notFound": "Not Found",
-  "status.sessionExpired": "Session Expired",
-  "status.cancelled": "Cancelled",
-  "status.undetermined": "Undetermined",
-  "status.unsupported": "Unsupported",
-  "status.sessionBusy": "Session Busy",
-  "status.externalError": "External Error",
+  "label_operations": "Operations",
+  "title_empty": "No operations data",
+  "pleaceholder_search": "Search operations",
+  "placeholder_kind": "Select operation kind",
+  "kind_ssBackgrounds": "SS/Backgrounds",
+  "kind_export": "Export",
+  "kind_buildIndex": "Build Index",
 
-  "column.operationId": "Operation ID",
-  "column.status": "Status",
-  "column.createdBy": "Created By",
-  "column.createTime": "Create Time",
-  "column.endTime": "End Time",
-  "column.duration": "Duration",
-  "duration.ongoing": "{{value}} (ongoing)"
+  "column_operationId": "Operation ID",
+  "column_status": "Status",
+  "column_createdBy": "Created By",
+  "column_createTime": "Create Time",
+  "column_endTime": "End Time",
+  "column_duration": "Duration",
+  "label_duration-ongoing": "{{value}} (ongoing)"
 }