Skip to content

Commit 2719739

Browse files
Anton StandrikAnton Standrik
authored andcommitted
fix: better code
1 parent 7ac1936 commit 2719739

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

tests/suites/sidebar/Sidebar.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@ export class Sidebar {
132132
await switchLabel.click();
133133
}
134134

135+
async getFirstExperimentTitle(): Promise<string> {
136+
const experimentItem = this.drawer.locator('.gn-settings__item-title').first();
137+
return experimentItem.innerText();
138+
}
139+
135140
async isExperimentEnabled(title: string): Promise<boolean> {
136141
const experimentItem = this.drawer
137142
.locator('.gn-settings__item-title')

tests/suites/sidebar/sidebar.test.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,23 +91,24 @@ test.describe('Test Sidebar', async () => {
9191
expect(itemsCount).toBeGreaterThan(0);
9292
});
9393

94-
test('Can toggle experiments in settings', async ({page}) => {
94+
test.only('Can toggle experiments in settings', async ({page}) => {
9595
const sidebar = new Sidebar(page);
96-
const experimentTitle = 'Plan to SVG';
96+
await sidebar.clickSettings();
97+
await page.waitForTimeout(500); // Wait for animation
98+
await sidebar.clickExperimentsSection();
99+
const experimentTitle = await sidebar.getFirstExperimentTitle();
97100

98101
await toggleExperiment(page, 'on', experimentTitle);
99102
await sidebar.clickSettings();
100103
await page.waitForTimeout(500); // Wait for animation
101104
await sidebar.clickExperimentsSection();
102-
await page.waitForTimeout(500); // Wait for animation
103105
const newState = await sidebar.isExperimentEnabled(experimentTitle);
104106
expect(newState).toBe(true);
105107

106108
await toggleExperiment(page, 'off', experimentTitle);
107109
await sidebar.clickSettings();
108110
await page.waitForTimeout(500); // Wait for animation
109111
await sidebar.clickExperimentsSection();
110-
await page.waitForTimeout(500); // Wait for animation
111112
const finalState = await sidebar.isExperimentEnabled(experimentTitle);
112113
expect(finalState).toBe(false);
113114
});

tests/utils/toggleExperiment.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,11 @@ export const toggleExperiment = async (page: Page, state: 'on' | 'off', title: s
1010
await page.waitForTimeout(500); // Wait for animation
1111
}
1212
await sidebar.clickExperimentsSection();
13-
await page.waitForTimeout(500); // Wait for animation
1413
const currentState = await sidebar.isExperimentEnabled(title);
1514
const desiredState = state === 'on';
1615

1716
if (currentState !== desiredState) {
1817
await sidebar.toggleExperimentByTitle(title);
19-
await page.waitForTimeout(500); // Wait for animation
2018
}
2119

2220
if (await sidebar.isDrawerVisible()) {

0 commit comments

Comments
 (0)