Skip to content

Commit 2960911

Browse files
committed
fix: linters
1 parent cb0e908 commit 2960911

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

src/components/ProgressWrapper/SingleProgress.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ export function SingleProgress({
2525
size = PROGRESS_SIZE,
2626
withCapacityUsage = false,
2727
}: ProgressWrapperSingleProps) {
28-
if (!isValidValue(value)) {
29-
return <div className={className}>{i18n('alert_no-data')}</div>;
30-
}
31-
3228
const numericValue = safeParseNumber(value);
3329
const numericCapacity = safeParseNumber(capacity);
3430
const clampedFillWidth = calculateProgressWidth(numericValue, numericCapacity);
@@ -41,6 +37,10 @@ export function SingleProgress({
4137
return formatProgressText(valueText, capacityText, numericCapacity);
4238
}, [valueText, capacityText, numericCapacity]);
4339

40+
if (!isValidValue(value)) {
41+
return <div className={className}>{i18n('alert_no-data')}</div>;
42+
}
43+
4444
return (
4545
<ProgressContainer
4646
displayText={displayText}

src/components/ProgressWrapper/StackProgress.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ export function StackProgress({
2929
return stack.filter((segment) => !segment.isInfo && segment.value > 0);
3030
}, [stack]);
3131

32-
if (displaySegments.length === 0) {
33-
return <div className={className}>{i18n('alert_no-data')}</div>;
34-
}
35-
3632
const totalValue = React.useMemo(() => {
3733
return displaySegments.reduce((sum, segment) => sum + segment.value, 0);
3834
}, [displaySegments]);
@@ -59,6 +55,10 @@ export function StackProgress({
5955
return formatProgressText(totalValueText, totalCapacityText, numericTotalCapacity || 0);
6056
}, [totalValueText, totalCapacityText, numericTotalCapacity]);
6157

58+
if (displaySegments.length === 0) {
59+
return <div className={className}>{i18n('alert_no-data')}</div>;
60+
}
61+
6262
return (
6363
<ProgressContainer
6464
displayText={displayText}

src/components/QueriesActivityBar/QueriesActivityCharts.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,6 @@ export function QueriesActivityCharts({
3838
const queriesChartConfig = getChartByTarget('queries.requests');
3939
const latenciesChartConfig = getChartByTarget('queries.latencies.p99');
4040

41-
// Early return if required charts are not found
42-
if (!queriesChartConfig || !latenciesChartConfig) {
43-
console.warn('Required chart configurations not found in defaultDashboardConfig');
44-
return null;
45-
}
46-
4741
// Refetch data only if charts have successfully loaded at least once
4842
const shouldRefresh = hasChartsLoaded ? autoRefreshInterval : 0;
4943

@@ -58,6 +52,12 @@ export function QueriesActivityCharts({
5852
[onChartDataStatusChange],
5953
);
6054

55+
// Early return if required charts are not found
56+
if (!queriesChartConfig || !latenciesChartConfig) {
57+
console.warn('Required chart configurations not found in defaultDashboardConfig');
58+
return null;
59+
}
60+
6161
// WORKAROUND: Charts are rendered outside Disclosure component due to YAGR tooltip bug
6262
// Issue: https://github.com/gravity-ui/yagr/issues/262
6363

0 commit comments

Comments
 (0)