Skip to content

Commit 2ce27ab

Browse files
committed
fix: review
1 parent 56713a2 commit 2ce27ab

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed

src/containers/Tenant/Healthcheck/Healthcheck.scss

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,24 @@
2121
&__issues {
2222
padding: 0 var(--g-spacing-4) var(--g-spacing-4) var(--g-spacing-4);
2323
}
24+
25+
&__animation-container {
26+
overflow: hidden;
27+
28+
min-height: 0;
29+
}
2430
&__issue-wrapper {
2531
border: 1px solid var(--g-color-line-generic);
2632
border-radius: var(--g-border-radius-s);
27-
2833
.g-disclosure_enter_active {
2934
display: grid;
3035

31-
animation-name: disclosure-expanded;
32-
animation-duration: 0.2s;
36+
animation: disclosure-expanded 0.4s cubic-bezier(0.23, 1, 0.32, 1) forwards;
3337
}
3438
.g-disclosure_exit_active {
3539
display: grid;
3640

37-
animation-name: disclosure-collapsed;
38-
animation-duration: 0.1s;
41+
animation: disclosure-collapsed 0.4s cubic-bezier(0.23, 1, 0.32, 1) forwards;
3942
}
4043
}
4144
&__issue-summary {
@@ -86,8 +89,6 @@
8689
background-color: var(--g-color-text-danger);
8790
}
8891
&__issue-details {
89-
overflow: hidden;
90-
9192
padding: 0 var(--g-spacing-4) var(--g-spacing-4) var(--g-spacing-4);
9293
}
9394
}

src/containers/Tenant/Healthcheck/components/HealthcheckIssue.tsx

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,16 @@ export function HealthcheckIssue({issue, expanded}: HealthcheckIssueProps) {
7171
</div>
7272
)}
7373
</Disclosure.Summary>
74-
<Flex className={b('issue-details')} direction="column" gap={3} grow={1}>
75-
<HealthcheckIssueTabs
76-
parents={parents}
77-
selectedTab={selectedTab}
78-
setSelectedTab={setSelectedTab}
79-
/>
80-
{currentIssue && <IssueDetails issue={currentIssue} />}
81-
</Flex>
74+
<div className={b('animation-container')}>
75+
<Flex className={b('issue-details')} direction="column" gap={3} grow={1}>
76+
<HealthcheckIssueTabs
77+
parents={parents}
78+
selectedTab={selectedTab}
79+
setSelectedTab={setSelectedTab}
80+
/>
81+
{currentIssue && <IssueDetails issue={currentIssue} />}
82+
</Flex>
83+
</div>
8284
</Disclosure>
8385
</Flex>
8486
);

src/containers/Tenant/TenantDrawerWrappers.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export function TenantDrawerWrapper({children, database}: TenantDrawerWrapperPro
5757
drawerId="tenant-healthcheck-details"
5858
storageKey="tenant-healthcheck-details-drawer-width"
5959
detectClickOutside
60-
showVeil
60+
hideVeil={false}
6161
isPercentageWidth
6262
drawerControls={[
6363
{

0 commit comments

Comments
 (0)