chore: test test

Author: github-actions[bot]

.github/workflows/quality.yml

@@ -243,22 +243,43 @@ jobs:
               deleted: []
             };
 
+            // Helper function to extract all tests from a suite recursively
+            function extractTestsFromSuite(suite, parentTitle = '') {
+              let tests = [];
+              const fullSuiteTitle = parentTitle ? `${parentTitle} > ${suite.title}` : suite.title;
+              
+              // Add tests from specs
+              if (suite.specs) {
+                tests.push(...suite.specs.map(spec => ({
+                  title: `${fullSuiteTitle} > ${spec.title}`,
+                  status: spec.ok ? 'passed' : spec.skipped ? 'skipped' : 'failed',
+                  file: suite.file
+                })));
+              }
+              
+              // Recursively process nested suites
+              if (suite.suites) {
+                suite.suites.forEach(nestedSuite => {
+                  tests.push(...extractTestsFromSuite(nestedSuite, fullSuiteTitle));
+                });
+              }
+              
+              return tests;
+            }
+
             // Read current PR test results
             if (fs.existsSync(testResultsPath)) {
               const rawData = fs.readFileSync(testResultsPath);
               const data = JSON.parse(rawData);
+              const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
+              
               testResults = {
                 total: data.stats.expected + data.stats.unexpected + data.stats.flaky + data.stats.skipped,
                 passed: data.stats.expected,
                 failed: data.stats.unexpected,
                 flaky: data.stats.flaky,
                 skipped: data.stats.skipped,
-                tests: data.suites.flatMap(suite => 
-                  suite.specs.map(spec => ({
-                    title: `${suite.title} ${spec.title}`,
-                    status: spec.ok ? 'passed' : spec.skipped ? 'skipped' : 'failed'
-                  }))
-                )
+                tests: allTests
               };
             } else {
               console.log('Test results file not found');
@@ -269,40 +290,34 @@ jobs:
             if (fs.existsSync(mainTestResultsPath)) {
               const rawData = fs.readFileSync(mainTestResultsPath);
               const data = JSON.parse(rawData);
-              mainTestResults = {
-                tests: data.suites.flatMap(suite => 
-                  suite.specs.map(spec => ({
-                    title: `${suite.title} ${spec.title}`,
-                    status: spec.ok ? 'passed' : spec.skipped ? 'skipped' : 'failed'
-                  }))
-                )
-              };
+              const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
+              mainTestResults = { tests: allTests };
 
               // Compare tests
-              const currentTests = new Set(testResults.tests.map(t => t.title));
-              const mainTests = new Set(mainTestResults.tests.map(t => t.title));
+              const currentTests = new Map(testResults.tests.map(t => [t.title, t]));
+              const mainTests = new Map(mainTestResults.tests.map(t => [t.title, t]));
 
               // Find new tests
-              testResults.tests.forEach(test => {
-                if (!mainTests.has(test.title)) {
-                  testComparison.new.push(test.title);
+              for (const [title, test] of currentTests) {
+                if (!mainTests.has(title)) {
+                  testComparison.new.push(`${test.file}: ${title}`);
                 }
-              });
+              }
 
               // Find deleted tests
-              mainTestResults.tests.forEach(test => {
-                if (!currentTests.has(test.title)) {
-                  testComparison.deleted.push(test.title);
+              for (const [title, test] of mainTests) {
+                if (!currentTests.has(title)) {
+                  testComparison.deleted.push(`${test.file}: ${title}`);
                 }
-              });
+              }
 
               // Find newly skipped tests
-              testResults.tests.forEach(test => {
-                const mainTest = mainTestResults.tests.find(t => t.title === test.title);
+              for (const [title, test] of currentTests) {
+                const mainTest = mainTests.get(title);
                 if (mainTest && mainTest.status !== 'skipped' && test.status === 'skipped') {
-                  testComparison.skipped.push(test.title);
+                  testComparison.skipped.push(`${test.file}: ${title}`);
                 }
-              });
+              }
             } else {
               console.log('Main branch test results file not found');
               mainTestResults = { tests: [] };

tests/suites/tenant/queryEditor/queryEditor.test.ts

@@ -52,7 +52,7 @@ test.describe('Test Query Editor', async () => {
         await expect(explainJSON).toBeVisible({timeout: VISIBILITY_TIMEOUT});
     });
 
-    test.only('Explain button executes Scan explanation', async ({page}) => {
+    test.skip('Explain button executes Scan explanation', async ({page}) => {
         const queryEditor = new QueryEditor(page);
         await queryEditor.explain(testQuery, QUERY_MODES.scan);
 
@@ -66,7 +66,19 @@ test.describe('Test Query Editor', async () => {
         await expect(explainAST).toBeVisible({timeout: VISIBILITY_TIMEOUT});
     });
 
-    test('Run and and Explain buttons are disabled when query is empty', async ({page}) => {
+    test('Error is displayed for invalid query', async ({page}) => {
+        const queryEditor = new QueryEditor(page);
+
+        const invalidQuery = 'Select d';
+        await queryEditor.setQuery(invalidQuery);
+        await queryEditor.clickRunButton();
+
+        await expect(queryEditor.waitForStatus('Failed')).resolves.toBe(true);
+        const errorMessage = await queryEditor.getErrorMessage();
+        await expect(errorMessage).toContain('Column references are not allowed without FROM');
+    });
+
+    test('Run and Explain buttons are disabled for empty query', async ({page}) => {
         const queryEditor = new QueryEditor(page);
 
         await expect(queryEditor.isRunButtonEnabled()).resolves.toBe(false);
@@ -78,7 +90,7 @@ test.describe('Test Query Editor', async () => {
         await expect(queryEditor.isExplainButtonEnabled()).resolves.toBe(true);
     });
 
-    test('Stop and button and elapsed time label appears when query is running', async ({page}) => {
+    test('Stop button and elapsed time label appear when query is running', async ({page}) => {
         const queryEditor = new QueryEditor(page);
 
         await queryEditor.setQuery(longRunningQuery);
@@ -88,7 +100,7 @@ test.describe('Test Query Editor', async () => {
         await expect(queryEditor.isElapsedTimeVisible()).resolves.toBe(true);
     });
 
-    test('Stop button and elapsed time label disappears after query is stopped', async ({page}) => {
+    test('Stop button and elapsed time label disappear after query is stopped', async ({page}) => {
         const queryEditor = new QueryEditor(page);
 
         await queryEditor.setQuery(longRunningQuery);
@@ -102,7 +114,7 @@ test.describe('Test Query Editor', async () => {
         await expect(queryEditor.isElapsedTimeHidden()).resolves.toBe(true);
     });
 
-    test('Query execution is terminated when stop button is clicked', async ({page}) => {
+    test.only('Query execution is terminated when stop button is clicked', async ({page}) => {
         const queryEditor = new QueryEditor(page);
 
         await queryEditor.setQuery(longRunningQuery);