fix: better code

Author: astandrik

src/components/QueryResultTable/QueryResultTable.tsx

@@ -21,7 +21,7 @@ const TABLE_SETTINGS: Settings = {
     ...DEFAULT_TABLE_SETTINGS,
     stripedRows: true,
     sortable: false,
-    displayIndices: {maxIndex: 100000},
+    displayIndices: true,
 };
 
 export const b = cn('ydb-query-result-table');
@@ -77,6 +77,7 @@ interface QueryResultTableProps
     extends Omit<ResizeableDataTableProps<KeyValueRow>, 'data' | 'columns'> {
     data?: KeyValueRow[];
     columns?: ColumnType[];
+    settings?: Partial<Settings>;
 }
 
 export const QueryResultTable = (props: QueryResultTableProps) => {
@@ -100,7 +101,7 @@ export const QueryResultTable = (props: QueryResultTableProps) => {
         <ResizeableDataTable
             data={data}
             columns={columns}
-            settings={TABLE_SETTINGS}
+            settings={{...TABLE_SETTINGS, ...props.settings}}
             // prevent accessing row.id in case it is present but is not the PK (i.e. may repeat)
             rowKey={getRowIndex}
             visibleRowIndex={getVisibleRowIndex}

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 
+import type {Settings} from '@gravity-ui/react-data-table';
 import {isEqual} from 'lodash';
 import {v4 as uuidv4} from 'uuid';
 
@@ -265,6 +266,11 @@ export default function QueryEditor(props: QueryEditorProps) {
                         showPreview={showPreview}
                         queryText={lastExecutedQueryText}
                         onCancelRunningQuery={handleCancelRunningQuery}
+                        tableSettings={
+                            isStreamingEnabled && querySettings.limitRows
+                                ? {displayIndices: {maxIndex: querySettings.limitRows}}
+                                : undefined
+                        }
                     />
                 </div>
             </SplitPane>
@@ -285,6 +291,7 @@ interface ResultProps {
     path: string;
     showPreview?: boolean;
     queryText: string;
+    tableSettings?: Partial<Settings>;
     onCancelRunningQuery: VoidFunction;
 }
 function Result({
@@ -299,6 +306,7 @@ function Result({
     path,
     showPreview,
     queryText,
+    tableSettings,
     onCancelRunningQuery,
 }: ResultProps) {
     if (showPreview) {
@@ -315,6 +323,7 @@ function Result({
                 isResultsCollapsed={resultVisibilityState.collapsed}
                 isCancelError={Boolean(cancelQueryResponse?.error)}
                 isCancelling={Boolean(cancelQueryResponse?.isLoading)}
+                tableSettings={tableSettings}
                 onExpandResults={onExpandResultHandler}
                 onCollapseResults={onCollapseResultHandler}
                 queryText={queryText}

src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx

@@ -1,5 +1,6 @@
 import React from 'react';
 
+import type {Settings} from '@gravity-ui/react-data-table';
 import type {ControlGroupOption} from '@gravity-ui/uikit';
 import {ClipboardButton, RadioButton} from '@gravity-ui/uikit';
 
@@ -82,6 +83,7 @@ interface ExecuteResultProps {
     theme?: string;
     tenantName: string;
     queryText?: string;
+    tableSettings?: Partial<Settings>;
 
     isCancelling: boolean;
     isCancelError: boolean;
@@ -99,6 +101,7 @@ export function QueryResultViewer({
     queryText,
     isCancelling,
     isCancelError,
+    tableSettings,
     onCancelRunningQuery,
     onCollapseResults,
     onExpandResults,
@@ -230,6 +233,7 @@ export function QueryResultViewer({
                     resultSets={resultSets}
                     error={error}
                     selectedResultSet={selectedResultSet}
+                    tableSettings={tableSettings}
                     setSelectedResultSet={setSelectedResultSet}
                 />
             );

src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.tsx

@@ -1,3 +1,4 @@
+import type {Settings} from '@gravity-ui/react-data-table';
 import {Tabs, Text} from '@gravity-ui/uikit';
 
 import {QueryResultTable} from '../../../../../../components/QueryResultTable';
@@ -15,6 +16,7 @@ interface ResultSetsViewerProps {
     resultSets?: ParsedResultSet[];
     selectedResultSet: number;
     error?: unknown;
+    tableSettings?: Partial<Settings>;
     setSelectedResultSet: (resultSet: number) => void;
 }
 
@@ -73,7 +75,11 @@ export function ResultSetsViewer(props: ResultSetsViewerProps) {
             {currentResult ? (
                 <div className={b('result')}>
                     {renderResultHeadWithCount()}
-                    <QueryResultTable data={currentResult.result} columns={currentResult.columns} />
+                    <QueryResultTable
+                        settings={props.tableSettings}
+                        data={currentResult.result}
+                        columns={currentResult.columns}
+                    />
                 </div>
             ) : null}
         </div>