fix: dont save full plan

Author: Anton Standrik

src/utils/hooks/useQueryExecutionSettings.ts

@@ -1,3 +1,5 @@
+import React from 'react';
+
 import {useTracingLevelOptionAvailable} from '../../store/reducers/capabilities/hooks';
 import type {QuerySettings} from '../../types/store/query';
 import {QUERY_EXECUTION_SETTINGS_KEY, USE_SHOW_PLAN_SVG_KEY} from '../constants';
@@ -12,6 +14,18 @@ export const useQueryExecutionSettings = () => {
     const validatedSettings = querySettingsRestoreSchema.parse(storageSettings);
     const [useShowPlanToSvg] = useSetting<boolean>(USE_SHOW_PLAN_SVG_KEY);
 
+    const setQueryExecutionSettings = React.useCallback(
+        (settings: QuerySettings) => {
+            setSettings({
+                ...settings,
+                statisticsMode: useShowPlanToSvg
+                    ? validatedSettings.statisticsMode
+                    : settings.statisticsMode,
+            });
+        },
+        [setSettings, useShowPlanToSvg, validatedSettings.statisticsMode],
+    );
+
     const settings: QuerySettings = {
         ...validatedSettings,
         statisticsMode: useShowPlanToSvg ? STATISTICS_MODES.full : validatedSettings.statisticsMode,
@@ -20,5 +34,5 @@ export const useQueryExecutionSettings = () => {
             : DEFAULT_QUERY_SETTINGS.tracingLevel,
     };
 
-    return [settings, setSettings] as const;
+    return [settings, setQueryExecutionSettings] as const;
 };

tests/suites/tenant/queryEditor/planToSvg.test.ts

@@ -4,7 +4,7 @@ import {tenantName} from '../../../utils/constants';
 import {toggleExperiment} from '../../../utils/toggleExperiment';
 import {TenantPage} from '../TenantPage';
 
-import {ButtonNames, QueryEditor} from './models/QueryEditor';
+import {QueryEditor} from './models/QueryEditor';
 
 test.describe('Test Plan to SVG functionality', async () => {
     const testQuery = 'SELECT 1;'; // Simple query that will generate a plan
@@ -24,30 +24,25 @@ test.describe('Test Plan to SVG functionality', async () => {
         const queryEditor = new QueryEditor(page);
 
         // 1. Turn on Plan to SVG experiment
-        await toggleExperiment(page, 'on', 'Plan to SVG');
+        await toggleExperiment(page, 'on', 'Execution plan');
 
-        // 2. Set stats level to Full
-        await queryEditor.clickGearButton();
-        await queryEditor.settingsDialog.changeStatsLevel('Full');
-        await queryEditor.settingsDialog.clickButton(ButtonNames.Save);
-
-        // 3. Set query and run it
+        // 2. Set query and run it
         await queryEditor.setQuery(testQuery);
         await queryEditor.clickRunButton();
 
-        // 4. Wait for query execution to complete
+        // 3. Wait for query execution to complete
         await expect(async () => {
             const status = await queryEditor.getExecutionStatus();
             expect(status).toBe('Completed');
         }).toPass();
 
-        // 5. Check if Execution Plan button appears and click it
+        // 4. Check if Execution Plan button appears and click it
         const executionPlanButton = page.locator('button:has-text("Execution plan")');
         await expect(executionPlanButton).toBeVisible();
         await executionPlanButton.click();
         await page.waitForTimeout(1000); // Wait for new tab to open
 
-        // 6. Verify we're taken to a new tab with SVG content
+        // 5. Verify we're taken to a new tab with SVG content
         const svgElement = page.locator('svg').first();
         await expect(svgElement).toBeVisible();
     });