fix: review

Author: Raubzeug

src/components/FormattedBytes/FormattedBytes.tsx

@@ -1,6 +1,6 @@
 import type {BytesSizes} from '../../utils/bytesParsers';
 import {formatBytes} from '../../utils/bytesParsers';
-import type {FormatValuesArgs} from '../../utils/bytesParsers/common';
+import type {FormatValuesArgs} from '../../utils/dataFormatters/common';
 
 type FormattedBytesProps = FormatValuesArgs<BytesSizes>;
 

src/components/FormattedBytes/utils.tsx

@@ -1,5 +1,5 @@
 import type {BytesSizes} from '../../utils/bytesParsers';
-import type {FormatValuesArgs} from '../../utils/bytesParsers/common';
+import type {FormatValuesArgs} from '../../utils/dataFormatters/common';
 
 import {FormattedBytes} from './FormattedBytes';
 

src/utils/bytesParsers/formatBytes.ts

@@ -1,8 +1,8 @@
 import {GIGABYTE, KILOBYTE, MEGABYTE, TERABYTE} from '../constants';
+import type {FormatToSizeArgs, FormatValuesArgs} from '../dataFormatters/common';
 import {formatNumber, roundToPrecision} from '../dataFormatters/dataFormatters';
 import {UNBREAKABLE_GAP, isNumeric} from '../utils';
 
-import type {FormatToSizeArgs, FormatValuesArgs} from './common';
 import i18n from './i18n';
 
 const sizes = {

src/utils/bytesParsers/common.ts renamed to src/utils/dataFormatters/common.ts

@@ -1,18 +1,18 @@
 import {dateTimeParse} from '@gravity-ui/date-utils';
 
 import type {TVDiskID, TVSlotId} from '../../types/api/vdisk';
-import {formatValues} from '../bytesParsers/common';
 import {
     formatBytes as formatBytesCustom,
     getSizeWithSignificantDigits,
 } from '../bytesParsers/formatBytes';
 import type {BytesSizes} from '../bytesParsers/formatBytes';
-import type {Digits} from '../bytesParsers/formatNumber';
-import {formatNumberWithDigits, getNumberWithSignificantDigits} from '../bytesParsers/formatNumber';
 import {DAY_IN_SECONDS, HOUR_IN_SECONDS} from '../constants';
 import {configuredNumeral} from '../numeral';
 import {isNumeric} from '../utils';
 
+import {formatValues} from './common';
+import {formatNumberWithDigits, getNumberWithSignificantDigits} from './formatNumber';
+import type {Digits} from './formatNumber';
 import i18n from './i18n';
 
 // Here you can't control displayed size and precision

src/utils/dataFormatters/dataFormatters.ts

@@ -1,8 +1,8 @@
-import {formatNumber, roundToPrecision} from '../dataFormatters/dataFormatters';
+import i18n from '../bytesParsers/i18n';
 import {UNBREAKABLE_GAP, isNumeric} from '../utils';
 
 import type {FormatToSizeArgs, FormatValuesArgs} from './common';
-import i18n from './i18n';
+import {formatNumber, roundToPrecision} from './dataFormatters';
 
 const sizes = {
     thousand: {
@@ -32,7 +32,7 @@ export type Digits = keyof typeof sizes;
  * @returns size to format value to get required number of digits
  *
  * By default value converted to the next size when it's above 1000,
- * so we have 900mb and 1gb. To extend it additional significantDigits could be set
+ * so we have 900k and 1m. To extend it additional significantDigits could be set
  *
  * significantDigits value added above default 3
  *
@@ -45,7 +45,7 @@ export type Digits = keyof typeof sizes;
 export const getNumberWithSignificantDigits = (value: number, significantDigits: number) => {
     const multiplier = 10 ** significantDigits;
 
-    const thousandLevel = sizes.million.value * multiplier;
+    const thousandLevel = sizes.thousand.value * multiplier;
     const millionLevel = sizes.million.value * multiplier;
     const billionLevel = sizes.billion.value * multiplier;
     const trillionLevel = sizes.trillion.value * multiplier;