Skip to content

Commit 47347f3

Browse files
committed
fix: review
1 parent 6efccef commit 47347f3

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

src/containers/Clusters/columns.tsx

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -358,19 +358,26 @@ interface VersionsProps {
358358
}
359359

360360
function Versions({row}: VersionsProps) {
361-
const {preparedVersions, name: clusterName, preparedBackend: backend, settings} = row;
361+
const {
362+
preparedVersions,
363+
name: clusterName,
364+
preparedBackend: backend,
365+
settings,
366+
use_embedded_ui: useEmbeddedUi,
367+
} = row;
362368
if (!preparedVersions.length) {
363369
return null;
364370
}
371+
const clusterPath =
372+
useEmbeddedUi && backend
373+
? createDeveloperUIMonitoringPageHref(backend)
374+
: getClusterPath(
375+
{activeTab: clusterTabsIds.versions, environment: settings?.auth_service},
376+
{backend, clusterName},
377+
{withBasename: true},
378+
);
365379
return (
366-
<ExternalLink
367-
className={b('cluster-versions')}
368-
href={getClusterPath(
369-
{activeTab: clusterTabsIds.versions, environment: settings?.auth_service},
370-
{backend, clusterName},
371-
{withBasename: true},
372-
)}
373-
>
380+
<ExternalLink className={b('cluster-versions')} href={clusterPath}>
374381
<VersionsBar preparedVersions={preparedVersions} />
375382
</ExternalLink>
376383
);

src/routes.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {useCallback} from 'react';
1+
import * as React from 'react';
22

33
import type {Location} from 'history';
44
import isEmpty from 'lodash/isEmpty';
@@ -64,7 +64,6 @@ type Query = AnyRecord;
6464

6565
export interface CreateHrefOptions {
6666
withBasename?: boolean;
67-
withEnv?: boolean;
6867
}
6968

7069
export function createHref(
@@ -171,7 +170,7 @@ type TabletPageQuery = QueryParamsTypeFromQueryObject<typeof tabletPageQueryPara
171170
export function useVDiskPagePath() {
172171
const database = useDatabaseFromQuery();
173172

174-
return useCallback(
173+
return React.useCallback(
175174
(
176175
params: {
177176
nodeId: string | number | undefined;
@@ -191,7 +190,7 @@ export function useVDiskPagePath() {
191190
export function useStorageGroupPath() {
192191
const database = useDatabaseFromQuery();
193192

194-
return useCallback(
193+
return React.useCallback(
195194
(groupId: string | number, query: Query = {}) => {
196195
return createHref(routes.storageGroup, undefined, {...query, groupId, database});
197196
},
@@ -202,7 +201,7 @@ export function useStorageGroupPath() {
202201
export function useTabletPagePath() {
203202
const database = useDatabaseFromQuery();
204203

205-
return useCallback(
204+
return React.useCallback(
206205
(tabletId: string | number, query: TabletPageQuery = {}) => {
207206
return createHref(routes.tablet, {id: tabletId}, {...query, database});
208207
},

0 commit comments

Comments
 (0)