fix: tracing issues

Author: astandrik

src/containers/Tenant/Query/ExecuteResult/TraceButton.tsx

@@ -5,14 +5,10 @@ import {Button} from '@gravity-ui/uikit';
 
 import {useClusterBaseInfo} from '../../../../store/reducers/cluster/cluster';
 import {traceApi} from '../../../../store/reducers/trace';
-import {SECOND_IN_MS} from '../../../../utils/constants';
-import {useDelayed} from '../../../../utils/hooks/useDelayed';
 import {replaceParams} from '../utils/replaceParams';
 
 import i18n from './i18n';
 
-const TIME_BEFORE_CHECK = 15 * SECOND_IN_MS;
-
 interface TraceUrlButtonProps {
     traceId: string;
 }
@@ -23,27 +19,25 @@ export function TraceButton({traceId}: TraceUrlButtonProps) {
     const checkTraceUrl = traceCheck?.url ? replaceParams(traceCheck.url, {traceId}) : '';
     const traceUrl = traceView?.url ? replaceParams(traceView.url, {traceId}) : '';
 
-    // We won't get any trace data at first 15 seconds for sure
-    const [readyToFetch, resetDelay] = useDelayed(TIME_BEFORE_CHECK);
+    const [checkTrace, {isLoading, isUninitialized}] = traceApi.useCheckTraceMutation();
 
     React.useEffect(() => {
-        resetDelay();
-    }, [traceId, resetDelay]);
+        let checkTraceMutation: {abort: () => void} | null;
+        if (checkTraceUrl) {
+            checkTraceMutation = checkTrace({url: checkTraceUrl});
+        }
 
-    const {isFetching} = traceApi.useCheckTraceQuery(
-        {url: checkTraceUrl},
-        {skip: !checkTraceUrl || !readyToFetch},
-    );
+        return () => checkTraceMutation?.abort();
+    }, [checkTrace, checkTraceUrl]);
 
-    if (!traceUrl) {
+    if (!traceUrl || isUninitialized) {
         return null;
     }
 
-    const loading = !readyToFetch || isFetching;
     return (
         <Button
-            view={loading ? 'flat-secondary' : 'flat-info'}
-            loading={loading}
+            view={isLoading ? 'flat-secondary' : 'flat-info'}
+            loading={isLoading}
             href={traceUrl}
             target="_blank"
         >

src/services/api.ts

@@ -66,8 +66,9 @@ import {parseMetaCluster} from './parsers/parseMetaCluster';
 import {parseMetaTenants} from './parsers/parseMetaTenants';
 import {settingsManager} from './settings';
 
-const TRACE_CHECK_TIMEOUT = 2 * SECOND_IN_MS;
-const TRACE_API_ERROR_TIMEOUT = 10 * SECOND_IN_MS;
+const TRACE_RETRY_DELAY = 4 * SECOND_IN_MS;
+const TRACE_CHECK_TIMEOUT = 10 * SECOND_IN_MS;
+const TRACE_API_ERROR_RETRY_DELAY = 10 * SECOND_IN_MS;
 const MAX_TRACE_CHECK_RETRIES = 30;
 
 export type AxiosOptions = {
@@ -604,10 +605,10 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
                                 (error?.response?.status === 404 || error.code === 'ERR_NETWORK');
 
                             if (isTracingError) {
-                                return TRACE_CHECK_TIMEOUT;
+                                return TRACE_RETRY_DELAY;
                             }
 
-                            return TRACE_API_ERROR_TIMEOUT;
+                            return TRACE_API_ERROR_RETRY_DELAY;
                         },
                         shouldResetTimeout: true,
                         retryCondition: () => true,

src/store/reducers/trace.ts

@@ -6,7 +6,7 @@ interface CheckTraceParams {
 
 export const traceApi = api.injectEndpoints({
     endpoints: (build) => ({
-        checkTrace: build.query({
+        checkTrace: build.mutation({
             queryFn: async ({url}: CheckTraceParams, {signal}) => {
                 try {
                     const response = await window.api.checkTrace({url}, {signal});