fix: review fixes

Author: astandrik

src/components/MemoryViewer/MemoryViewer.tsx

@@ -4,10 +4,10 @@ import type {TMemoryStats} from '../../types/api/nodes';
 import {formatBytes} from '../../utils/bytesParsers';
 import {cn} from '../../utils/cn';
 import {GIGABYTE} from '../../utils/constants';
+import type {FormatProgressViewerValues} from '../../utils/progress';
 import {calculateProgressStatus} from '../../utils/progress';
 import {isNumeric} from '../../utils/utils';
 import {HoverPopup} from '../HoverPopup/HoverPopup';
-import type {FormatProgressViewerValues} from '../ProgressViewer/ProgressViewer';
 import {ProgressViewer} from '../ProgressViewer/ProgressViewer';
 
 import {calculateAllocatedMemory, getMemorySegments} from './utils';

src/components/ProgressViewer/ProgressViewer.tsx

@@ -1,8 +1,8 @@
 import {useTheme} from '@gravity-ui/uikit';
 
 import {cn} from '../../utils/cn';
-import {formatNumber, roundToPrecision} from '../../utils/dataFormatters/dataFormatters';
-import {calculateProgressStatus} from '../../utils/progress';
+import {calculateProgressStatus, defaultFormatProgressValues} from '../../utils/progress';
+import type {FormatProgressViewerValues} from '../../utils/progress';
 import {isNumeric} from '../../utils/utils';
 
 import './ProgressViewer.scss';
@@ -11,19 +11,6 @@ const b = cn('progress-viewer');
 
 type ProgressViewerSize = 'xs' | 's' | 'ns' | 'm' | 'n' | 'l' | 'head';
 
-export type FormatProgressViewerValues = (
-    value?: number,
-    capacity?: number,
-) => (string | number | undefined)[];
-
-const formatValue = (value?: number) => {
-    return formatNumber(roundToPrecision(Number(value), 2));
-};
-
-const defaultFormatValues: FormatProgressViewerValues = (value, total) => {
-    return [formatValue(value), formatValue(total)];
-};
-
 /*
 
 Props description:
@@ -56,7 +43,7 @@ export interface ProgressViewerProps {
 export function ProgressViewer({
     value,
     capacity,
-    formatValues = defaultFormatValues,
+    formatValues = defaultFormatProgressValues,
     percents,
     withOverflow,
     className,

src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx

@@ -2,7 +2,8 @@ import React from 'react';
 
 import {Flex, Progress, Text} from '@gravity-ui/uikit';
 
-import type {FormatProgressViewerValues} from '../../../../../components/ProgressViewer/ProgressViewer';
+import {defaultFormatProgressValues} from '../../../../../utils/progress';
+import type {FormatProgressViewerValues} from '../../../../../utils/progress';
 import {isNumeric, safeParseNumber} from '../../../../../utils/utils';
 
 import {DEFAULT_PROGRESS_WIDTH, MAX_PERCENTAGE, MIN_PERCENTAGE, PROGRESS_SIZE} from './constants';
@@ -16,14 +17,10 @@ interface ProgressWrapperProps {
     width?: number;
 }
 
-const defaultFormatValues: FormatProgressViewerValues = (value, total) => {
-    return [value, total];
-};
-
 export function ProgressWrapper({
     value,
     capacity,
-    formatValues = defaultFormatValues,
+    formatValues = defaultFormatProgressValues,
     className,
     width = DEFAULT_PROGRESS_WIDTH,
 }: ProgressWrapperProps) {

src/utils/progress.ts

@@ -1,7 +1,21 @@
 import {DEFAULT_DANGER_THRESHOLD, DEFAULT_WARNING_THRESHOLD} from './constants';
+import {formatNumber, roundToPrecision} from './dataFormatters/dataFormatters';
 
 export type ProgressStatus = 'good' | 'warning' | 'danger';
 
+export type FormatProgressViewerValues = (
+    value?: number,
+    capacity?: number,
+) => (string | number | undefined)[];
+
+const formatValue = (value?: number) => {
+    return formatNumber(roundToPrecision(Number(value), 2));
+};
+
+export const defaultFormatProgressValues: FormatProgressViewerValues = (value, total) => {
+    return [formatValue(value), formatValue(total)];
+};
+
 interface CalculateProgressStatusProps {
     inverseColorize?: boolean;
     dangerThreshold?: number;