fix: review

Author: Raubzeug

src/components/VDiskInfo/VDiskInfo.tsx

@@ -145,14 +145,10 @@ export function VDiskInfo<T extends PreparedVDisk>({
                 label: vDiskInfoKeyset('replication-progress'),
                 value: (
                     <ProgressViewer
-                        value={ReplicationProgress}
-                        capacity={1}
-                        formatValues={(value) => [`${Math.round((value || 0) * 100)}%`]}
+                        value={Math.round(ReplicationProgress * 100)}
+                        percents
                         colorizeProgress={true}
-                        inverseColorize={true}
-                        dangerThreshold={0}
-                        warningThreshold={0}
-                        hideCapacity={true}
+                        capacity={100}
                     />
                 ),
             });
@@ -191,28 +187,28 @@ export function VDiskInfo<T extends PreparedVDisk>({
     }
 
     // Show donors list when replication is in progress
-    if (Replicated === false && VDiskState === EVDiskState.OK && Donors && Donors.length > 0) {
+    if (Replicated === false && VDiskState === EVDiskState.OK && Donors?.length) {
         const donorLinks = Donors.map((donor, index) => {
-            if (!donor.StringifiedId) {
-                return null;
-            }
+            const {
+                StringifiedId: id,
+                NodeId: dNodeId,
+                PDiskId: dPDiskId,
+                VDiskSlotId: dVSlotId,
+            } = donor;
 
-            // Parse StringifiedId format: "nodeId-pDiskId-vDiskSlotId"
-            const parts = donor.StringifiedId.split('-');
-            if (parts.length !== 3) {
-                return donor.StringifiedId;
+            if (!id || !dVSlotId || !dNodeId || !dPDiskId) {
+                return null;
             }
 
-            const [nodeId, pDiskId, vDiskSlotId] = parts;
             const vDiskPath = getVDiskPagePath({
-                nodeId: parseInt(nodeId),
-                pDiskId: parseInt(pDiskId),
-                vDiskSlotId: parseInt(vDiskSlotId),
+                nodeId: dNodeId,
+                pDiskId: dPDiskId,
+                vDiskSlotId: dVSlotId,
             });
 
             return (
                 <InternalLink key={index} to={vDiskPath}>
-                    {donor.StringifiedId}
+                    {id}
                 </InternalLink>
             );
         }).filter(Boolean);

src/utils/disks/prepareDisks.ts

@@ -1,3 +1,5 @@
+import {isNil} from 'lodash';
+
 import {valueIsDefined} from '..';
 import type {TPDiskStateInfo} from '../../types/api/pdisk';
 import type {TVDiskStateInfo, TVSlotId} from '../../types/api/vdisk';
@@ -69,21 +71,21 @@ export function prepareWhiteboardVDiskData(
             return prepareWhiteboardVDiskData({...donor, DonorMode: true});
         } else {
             // TVSlotId data - create a minimal PreparedVDisk
-            const {NodeId: dNodeId, PDiskId: dPDiskId, VSlotId} = donor;
-            const StringifiedId = 
-                valueIsDefined(dNodeId) && valueIsDefined(dPDiskId) && valueIsDefined(VSlotId)
-                    ? `${dNodeId}-${dPDiskId}-${VSlotId}`
+            const {NodeId: dNodeId, PDiskId: dPDiskId, VSlotId: vSlotId} = donor;
+            const stringifiedId =
+                !isNil(dNodeId) && !isNil(dPDiskId) && !isNil(vSlotId)
+                    ? `${dNodeId}-${dPDiskId}-${vSlotId}`
                     : '';
-            
+
             return {
                 NodeId: dNodeId,
-                PDiskId: dPDiskId, 
-                VDiskSlotId: VSlotId,
-                StringifiedId,
+                PDiskId: dPDiskId,
+                VDiskSlotId: vSlotId,
+                StringifiedId: stringifiedId,
                 DonorMode: true,
-            } as PreparedVDisk;
+            };
         }
-    }).filter((donor) => donor.StringifiedId);
+    });
 
     return {
         ...restVDiskFields,