fix: linter issues

Author: Raubzeug

.eslintrc

@@ -7,10 +7,13 @@
     "root": true,
     "overrides": [
         {
-            "files": [
-                "config-overrides.js",
-                "commitlint.config.js"
-            ],
+            "files": ["*.js"],
+            "rules": {
+                "@typescript-eslint/consistent-type-imports": "off",
+            },
+        },
+        {
+            "files": ["config-overrides.js", "commitlint.config.js"],
             "env": {
                 "node": true,
             },
@@ -20,20 +23,14 @@
         "project": "./tsconfig.json",
     },
     "rules": {
-        "import/consistent-type-specifier-style": [
-            "error",
-            "prefer-top-level"
-        ],
+        "import/consistent-type-specifier-style": ["error", "prefer-top-level"],
         "@typescript-eslint/consistent-type-imports": [
             "error",
             {
                 "prefer": "type-imports",
-                "fixStyle": "separate-type-imports"
+                "fixStyle": "separate-type-imports",
             },
         ],
-        "curly": [
-            "error",
-            "all"
-        ],
+        "curly": ["error", "all"],
     },
 }

src/components/SplitPane/index.js renamed to src/components/SplitPane/index.ts

@@ -44,14 +44,12 @@
         .stack__layer + .stack__layer {
             transform: translate(
                 calc(
-                    var(--ydb-stack-level) * (var(--ydb-stack-offset-x-hover) * 2) - var(
-                            --ydb-stack-offset-x-hover
-                        )
+                    var(--ydb-stack-level) *
+                        (var(--ydb-stack-offset-x-hover) * 2) - var(--ydb-stack-offset-x-hover)
                 ),
                 calc(
-                    var(--ydb-stack-level) * (var(--ydb-stack-offset-y-hover) * 2) - var(
-                            --ydb-stack-offset-y-hover
-                        )
+                    var(--ydb-stack-level) *
+                        (var(--ydb-stack-offset-y-hover) * 2) - var(--ydb-stack-offset-y-hover)
                 )
             );
         }

src/components/Stack/Stack.scss

@@ -32,7 +32,7 @@ interface YdbUserDropdownProps {
 
 function UserDropdown({isCompact, popupAnchor, user, children}: YdbUserDropdownProps) {
     const [isUserDropdownVisible, setIsUserDropdownVisible] = React.useState(false);
-    const iconData = user ? user.icon ?? Person : userSecret;
+    const iconData = user ? (user.icon ?? Person) : userSecret;
     return (
         <FooterItem
             compact={isCompact}

src/containers/AsideNavigation/AsideNavigation.tsx

@@ -66,7 +66,7 @@ export function prepareQueryData(
                 ...result,
                 preparedPlan: {...preparePlan(planWithStats), pristine: planWithStats},
             };
-        } catch (e) {}
+        } catch {}
     }
 
     return result;

src/store/reducers/query/prepareQueryData.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-duplicate-imports */
 declare module 'redux-location-state' {
     import type {Dispatch, Middleware, PayloadAction, Reducer, Store} from '@reduxjs/toolkit';
     import type {History, Location} from 'history';

src/types/redux-location-state.d.ts

@@ -12,7 +12,7 @@ export const useLastQueryExecutionSettings = () => {
 
     try {
         lastSettings = querySettingsValidationSchema.parse(lastStorageSettings);
-    } catch (error) {
+    } catch {
         lastSettings = undefined;
     }
 

src/utils/hooks/useLastQueryExecutionSettings.ts

@@ -4,7 +4,7 @@ export function parseJson(value?: string | null) {
     }
     try {
         return JSON.parse(value);
-    } catch (err) {
+    } catch {
         return value;
     }
 }

src/utils/utils.ts

@@ -13,7 +13,7 @@ async function warmupApplication(appPage: PageModel) {
             await appPage.goto();
             await appPage.page.waitForLoadState('networkidle');
             await appPage.page.waitForTimeout(retryDelay);
-        } catch (error) {
+        } catch {
             if (i === maxRetries - 1) {
                 throw new Error('Application warmup failed after max retries');
             }

tests/playwrightSetup.ts

@@ -43,7 +43,7 @@ test.describe('Query Templates', () => {
         try {
             await queryEditor.waitForStatus('Failed');
             // If we reach here, the test passed because execution failed as expected
-        } catch (error) {
+        } catch {
             throw new Error('Update table template should not have executed successfully');
         }
     });
@@ -75,7 +75,7 @@ test.describe('Query Templates', () => {
                 // If not failed, verify it completed successfully
                 expect(status).toBe('Completed');
             }
-        } catch (error) {
+        } catch {
             throw new Error(
                 'Query execution neither completed successfully nor failed with expected error',
             );