Skip to content

Commit 570f883

Browse files
committed
fix: rm precision
1 parent 8404336 commit 570f883

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

src/components/MemoryViewer/MemoryViewer.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ const b = cn('memory-viewer');
1616
type FormatProgressViewerValues = (
1717
value?: number,
1818
capacity?: number,
19-
precision?: number,
2019
) => (string | number | undefined)[];
2120

2221
export interface MemoryProgressViewerProps {
@@ -30,8 +29,6 @@ export interface MemoryProgressViewerProps {
3029
dangerThreshold?: number;
3130
}
3231

33-
const MEMORY_PRECISION = 1;
34-
3532
export function MemoryViewer({
3633
stats,
3734
value,
@@ -54,7 +51,7 @@ export function MemoryViewer({
5451
capacityText = '';
5552
divider = '';
5653
} else if (formatValues) {
57-
[valueText, capacityText] = formatValues(Number(value), Number(capacity), MEMORY_PRECISION);
54+
[valueText, capacityText] = formatValues(Number(value), Number(capacity));
5855
}
5956

6057
const renderContent = () => {
@@ -108,13 +105,11 @@ export function MemoryViewer({
108105
<ProgressViewer
109106
value={segmentSize}
110107
capacity={segmentCapacity}
111-
formatValues={(val, size) =>
112-
formatValues(val, size, MEMORY_PRECISION)
113-
}
108+
formatValues={formatValues}
114109
colorizeProgress
115110
/>
116111
) : (
117-
formatValues(segmentSize, undefined, MEMORY_PRECISION)[0]
112+
formatValues(segmentSize, undefined)[0]
118113
)}
119114
</DefinitionList.Item>
120115
),

src/utils/dataFormatters/common.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export function formatValues<T>(
2222
size?: T,
2323
delimiter?: string,
2424
withValueLabel = false,
25-
precision?: number,
2625
) {
2726
let calculatedSize = sizeGetter(Number(value), 0);
2827
let valueWithSizeLabel = true;
@@ -38,7 +37,7 @@ export function formatValues<T>(
3837
value,
3938
withSizeLabel: valueWithSizeLabel,
4039
size: size || calculatedSize,
41-
precision: precision ?? valuePrecision,
40+
precision: valuePrecision,
4241
delimiter,
4342
});
4443
const formattedTotal = formatter({

src/utils/dataFormatters/dataFormatters.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ export function formatStorageValues(
6161
size?: BytesSizes,
6262
delimiter?: string,
6363
withValueLabel?: boolean,
64-
precision?: number,
6564
) {
6665
return formatValues<BytesSizes>(
6766
formatBytesCustom,
@@ -71,7 +70,6 @@ export function formatStorageValues(
7170
size,
7271
delimiter,
7372
withValueLabel,
74-
precision,
7573
);
7674
}
7775

@@ -93,12 +91,12 @@ export function formatNumericValues(
9391
);
9492
}
9593

96-
export const formatStorageValuesToGb = (value?: number, total?: number, precision?: number) => {
97-
return formatStorageValues(value, total, 'gb', undefined, undefined, precision);
94+
export const formatStorageValuesToGb = (value?: number, total?: number) => {
95+
return formatStorageValues(value, total, 'gb');
9896
};
9997

100-
export const formatStorageValuesToTb = (value?: number, total?: number, precision?: number) => {
101-
return formatStorageValues(value, total, 'tb', undefined, undefined, precision);
98+
export const formatStorageValuesToTb = (value?: number, total?: number) => {
99+
return formatStorageValues(value, total, 'tb');
102100
};
103101

104102
export const formatNumber = (number?: unknown) => {

0 commit comments

Comments
 (0)