Skip to content

Commit 5af61ac

Browse files
fix: do not send empty strings in filters (#1330)
1 parent c9ec3b7 commit 5af61ac

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/services/api.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,8 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
204204
tablets = false,
205205
database,
206206
tenant,
207-
fieldsRequired,
207+
fieldsRequired = 'all',
208+
filter,
208209
...params
209210
}: NodesRequestParams,
210211
{concurrentId, signal}: AxiosOptions = {},
@@ -218,6 +219,8 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
218219
{
219220
type,
220221
tablets,
222+
// Do not send empty string
223+
filter: filter || undefined,
221224
// TODO: remove after remove tenant param
222225
database: database || tenant,
223226
tenant: tenant || database,
@@ -228,7 +231,7 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
228231
);
229232
}
230233
getStorageInfo(
231-
{tenant, database, nodeId, groupId, pDiskId, ...params}: StorageRequestParams,
234+
{tenant, database, nodeId, groupId, pDiskId, filter, ...params}: StorageRequestParams,
232235
{concurrentId, signal}: AxiosOptions = {},
233236
) {
234237
return this.get<TStorageInfo>(
@@ -239,13 +242,15 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
239242
node_id: nodeId,
240243
group_id: groupId,
241244
pdisk_id: pDiskId,
245+
// Do not send empty string
246+
filter: filter || undefined,
242247
...params,
243248
},
244249
{concurrentId, requestConfig: {signal}},
245250
);
246251
}
247252
getStorageGroups(
248-
{nodeId, pDiskId, groupId, fieldsRequired = 'all', ...params}: GroupsRequestParams,
253+
{nodeId, pDiskId, groupId, fieldsRequired = 'all', filter, ...params}: GroupsRequestParams,
249254
{concurrentId, signal}: AxiosOptions = {},
250255
) {
251256
const preparedNodeId = Array.isArray(nodeId)
@@ -271,6 +276,8 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
271276
pdisk_id: preparedPDiskId,
272277
group_id: preparedGroupId,
273278
fields_required: preparedFieldsRequired,
279+
// Do not send empty string
280+
filter: filter || undefined,
274281
...params,
275282
},
276283
{concurrentId, requestConfig: {signal}},

0 commit comments

Comments
 (0)