Skip to content

Commit 61c52fc

Browse files
committed
fix: should not reset selected filters on scroll
1 parent bd476e9 commit 61c52fc

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,18 +164,15 @@ export function TopicData({parentRef, path, database}: TopicDataProps) {
164164
}, [handleSelectedOffsetChange, handleStartTimestampChange, topicDataFilter]);
165165

166166
const scrollToOffset = React.useCallback(
167-
(newOffset: number, reset?: boolean) => {
167+
(newOffset: number) => {
168168
const scrollTop = (newOffset - (baseOffset ?? 0)) * DEFAULT_TABLE_ROW_HEIGHT;
169169
const normalizedScrollTop = Math.max(0, scrollTop);
170170
parentRef.current?.scrollTo({
171171
top: normalizedScrollTop,
172172
behavior: 'instant',
173173
});
174-
if (reset) {
175-
resetFilters();
176-
}
177174
},
178-
[baseOffset, parentRef, resetFilters],
175+
[baseOffset, parentRef],
179176
);
180177

181178
React.useEffect(() => {

src/containers/Tenant/Diagnostics/TopicData/TopicDataControls/TopicDataControls.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ interface TopicDataControlsProps {
3838

3939
startOffset?: number;
4040
endOffset?: number;
41-
scrollToOffset: (start: number, reset?: boolean) => void;
41+
scrollToOffset: (offset: number) => void;
4242
}
4343

4444
export function TopicDataControls({
@@ -79,13 +79,13 @@ export function TopicDataControls({
7979

8080
const scrollToStartOffset = React.useCallback(() => {
8181
if (startOffset) {
82-
scrollToOffset(startOffset, true);
82+
scrollToOffset(startOffset);
8383
}
8484
}, [startOffset, scrollToOffset]);
8585

8686
const scrollToEndOffset = React.useCallback(() => {
8787
if (endOffset) {
88-
scrollToOffset(endOffset, true);
88+
scrollToOffset(endOffset);
8989
}
9090
}, [endOffset, scrollToOffset]);
9191

@@ -146,7 +146,7 @@ export function TopicDataControls({
146146
}
147147

148148
interface TopicDataStartControlsProps {
149-
scrollToOffset: (start: number, reset?: boolean) => void;
149+
scrollToOffset: (offset: number) => void;
150150
}
151151

152152
function TopicDataStartControls({scrollToOffset}: TopicDataStartControlsProps) {

0 commit comments

Comments
 (0)