Skip to content

Commit 67ff949

Browse files
refactor(UserSettings): add i18n (#398)
1 parent 158f56b commit 67ff949

File tree

4 files changed

+65
-17
lines changed

4 files changed

+65
-17
lines changed

src/containers/UserSettings/UserSettings.tsx

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import {
1313
} from '../../utils/constants';
1414

1515
import {Setting, SettingProps} from './Setting';
16+
import i18n from './i18n';
1617

1718
import './UserSettings.scss';
1819

@@ -27,15 +28,15 @@ enum Theme {
2728
const themeValues = [
2829
{
2930
value: Theme.system,
30-
content: 'System',
31+
content: i18n('settings.theme.option-system'),
3132
},
3233
{
3334
value: Theme.light,
34-
content: 'Light',
35+
content: i18n('settings.theme.option-light'),
3536
},
3637
{
3738
value: Theme.dark,
38-
content: 'Dark',
39+
content: i18n('settings.theme.option-dark'),
3940
},
4041
];
4142

@@ -53,13 +54,13 @@ export const UserSettings = ({settings}: UserSettingsProps) => {
5354
<Settings>
5455
<Settings.Page
5556
id={SettingsSection.general}
56-
title="General"
57+
title={i18n('page.general')}
5758
icon={{data: favoriteFilledIcon, height: 14, width: 14}}
5859
>
59-
<Settings.Section title="General">
60+
<Settings.Section title={i18n('section.general')}>
6061
<Setting
6162
settingKey={THEME_KEY}
62-
title="Interface theme"
63+
title={i18n('settings.theme.title')}
6364
type="radio"
6465
values={themeValues}
6566
/>
@@ -70,27 +71,23 @@ export const UserSettings = ({settings}: UserSettingsProps) => {
7071
</Settings.Page>
7172
<Settings.Page
7273
id={SettingsSection.experiments}
73-
title="Experiments"
74+
title={i18n('page.experiments')}
7475
icon={{data: flaskIcon}}
7576
>
76-
<Settings.Section title="Experiments">
77+
<Settings.Section title={i18n('section.experiments')}>
7778
<Setting
7879
settingKey={INVERTED_DISKS_KEY}
79-
title={'Inverted disks space indicators'}
80+
title={i18n('settings.invertedDisks.title')}
8081
/>
8182
<Setting
8283
settingKey={USE_NODES_ENDPOINT_IN_DIAGNOSTICS_KEY}
83-
title={'Break the Nodes tab in Diagnostics'}
84-
helpPopoverContent={
85-
'Use /viewer/json/nodes endpoint for Nodes Tab in diagnostics. It returns incorrect data on older versions'
86-
}
84+
title={i18n('settings.useNodesEndpoint.title')}
85+
helpPopoverContent={i18n('settings.useNodesEndpoint.popover')}
8786
/>
8887
<Setting
8988
settingKey={ENABLE_QUERY_MODES_FOR_EXPLAIN}
90-
title={'Enable query modes for explain'}
91-
helpPopoverContent={
92-
'Enable script | scan query mode selector for both run and explain. May not work on some versions'
93-
}
89+
title={i18n('settings.enableQueryModesForExplain.title')}
90+
helpPopoverContent={i18n('settings.enableQueryModesForExplain.popover')}
9491
/>
9592
{settings?.[SettingsSection.experiments]?.map((setting) => (
9693
<Setting key={setting.settingKey} {...setting} />
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"page.general": "General",
3+
"section.general": "General",
4+
5+
"page.experiments": "Experiments",
6+
"section.experiments": "Experiments",
7+
8+
"settings.theme.title": "Interface theme",
9+
"settings.theme.option-dark": "Dark",
10+
"settings.theme.option-light": "Light",
11+
"settings.theme.option-system": "System",
12+
13+
"settings.invertedDisks.title": "Inverted disks space indicators",
14+
15+
"settings.useNodesEndpoint.title": "Break the Nodes tab in Diagnostics",
16+
"settings.useNodesEndpoint.popover": "Use /viewer/json/nodes endpoint for Nodes Tab in diagnostics. It returns incorrect data on versions before 23-1",
17+
18+
"settings.enableQueryModesForExplain.title": "Enable query modes for explain",
19+
"settings.enableQueryModesForExplain.popover": "Enable script | scan query mode selector for both run and explain. May not work on versions before 23-2"
20+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import {i18n, Lang} from '../../../utils/i18n';
2+
3+
import en from './en.json';
4+
import ru from './ru.json';
5+
6+
const COMPONENT = 'ydb-user-settings';
7+
8+
i18n.registerKeyset(Lang.En, COMPONENT, en);
9+
i18n.registerKeyset(Lang.Ru, COMPONENT, ru);
10+
11+
export default i18n.keyset(COMPONENT);
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
{
2+
"page.general": "Общие",
3+
"section.general": "Общие",
4+
5+
"page.experiments": "Эксперименты",
6+
"section.experiments": "Эксперименты",
7+
8+
"settings.theme.title": "Тема",
9+
"settings.theme.option-dark": "Тёмная",
10+
"settings.theme.option-light": "Светлая",
11+
"settings.theme.option-system": "Системная",
12+
13+
"settings.invertedDisks.title": "Инвертированные индикаторы места на дисках",
14+
15+
"settings.useNodesEndpoint.title": "Сломать вкладку Nodes в диагностике",
16+
"settings.useNodesEndpoint.popover": "Использовать эндпоинт /viewer/json/nodes для вкладки Nodes в диагностике. Может возвращать некорректные данные на версиях до 23-1",
17+
18+
"settings.enableQueryModesForExplain.title": "Включить режимы выполнения запроса для explain",
19+
"settings.enableQueryModesForExplain.popover": "Включить общий переключатель script | scan для run и explain. Может работать некорректно на версиях до 23-2"
20+
}

0 commit comments

Comments
 (0)