fix(Storage): add message on empty nodes with small uptime

Author: artemmufazalov

src/containers/Storage/Storage.js

@@ -171,7 +171,8 @@ class Storage extends React.Component {
     }
 
     renderDataTable() {
-        const {flatListStorageEntities, visibleEntities, nodes, storageType} = this.props;
+        const {flatListStorageEntities, visibleEntities, nodesUptimeFilter, nodes, storageType} =
+            this.props;
 
         return (
             <div className={b('table-wrapper')}>
@@ -187,9 +188,10 @@ class Storage extends React.Component {
                 {storageType === StorageTypes.nodes && (
                     <StorageNodes
                         visibleEntities={visibleEntities}
+                        nodesUptimeFilter={nodesUptimeFilter}
                         data={flatListStorageEntities}
                         tableSettings={tableSettings}
-                        onShowAll={() => this.onGroupVisibilityChange(VisibleEntities.All)}
+                        onShowAll={this.onShowAllNodes}
                     />
                 )}
             </div>

src/containers/Storage/StorageNodes/StorageNodes.tsx

@@ -5,6 +5,7 @@ import DataTable, {Column, Settings, SortOrder} from '@yandex-cloud/react-data-t
 import {Popover, PopoverBehavior} from '@gravity-ui/uikit';
 
 import {VisibleEntities} from '../../../store/reducers/storage';
+import {NodesUptimeFilterValues} from '../../../utils/nodes';
 
 import {EmptyFilter} from '../EmptyFilter/EmptyFilter';
 import Pdisk from '../Pdisk/Pdisk';
@@ -28,6 +29,7 @@ interface StorageNodesProps {
     nodes: any;
     tableSettings: Settings;
     visibleEntities: keyof typeof VisibleEntities;
+    nodesUptimeFilter: keyof typeof NodesUptimeFilterValues;
     onShowAll?: VoidFunction;
 }
 
@@ -61,7 +63,13 @@ function setSortOrder(visibleEntities: keyof typeof VisibleEntities): SortOrder
     }
 }
 
-function StorageNodes({data, tableSettings, visibleEntities, onShowAll}: StorageNodesProps) {
+function StorageNodes({
+    data,
+    tableSettings,
+    visibleEntities,
+    onShowAll,
+    nodesUptimeFilter,
+}: StorageNodesProps) {
     const allColumns: Column<any>[] = [
         {
             name: TableColumnsIds.NodeId,
@@ -124,25 +132,33 @@ function StorageNodes({data, tableSettings, visibleEntities, onShowAll}: Storage
 
     if (visibleEntities === VisibleEntities.Space) {
         columns = allColumns.filter((col) => col.name !== TableColumnsIds.Missing);
+    }
+
+    if (!data.length) {
+        let message;
 
-        if (!data.length) {
-            return (
-                <EmptyFilter
-                    title={i18n('empty.out_of_space')}
-                    showAll={i18n('show_all')}
-                    onShowAll={onShowAll}
-                />
-            );
+        if (visibleEntities === VisibleEntities.Space) {
+            message = i18n('empty.out_of_space');
+        }
+
+        if (visibleEntities === VisibleEntities.Missing) {
+            message = i18n('empty.degraded');
+        }
+
+        if (nodesUptimeFilter === NodesUptimeFilterValues.SmallUptime) {
+            message = i18n('empty.small_uptime');
+        }
+
+        if (
+            visibleEntities !== VisibleEntities.All &&
+            nodesUptimeFilter !== NodesUptimeFilterValues.All
+        ) {
+            message = i18n('empty.several_filters');
+        }
+
+        if (message) {
+            return <EmptyFilter title={message} showAll={i18n('show_all')} onShowAll={onShowAll} />;
         }
-    }
-    if (visibleEntities === VisibleEntities.Missing && !data.length) {
-        return (
-            <EmptyFilter
-                title={i18n('empty.degraded')}
-                showAll={i18n('show_all')}
-                onShowAll={onShowAll}
-            />
-        );
     }
 
     return data ? (

src/containers/Storage/StorageNodes/i18n/en.json

@@ -1,6 +1,8 @@
 {
-    "empty.default": "No such nodes",
-    "empty.out_of_space": "No nodes with out of space errors",
-    "empty.degraded": "No degraded nodes",
-    "show_all": "Show all nodes"
+  "empty.default": "No such nodes",
+  "empty.out_of_space": "No nodes with out of space errors",
+  "empty.degraded": "No degraded nodes",
+  "empty.small_uptime": "No nodes with uptime < 1h",
+  "empty.several_filters": "No nodes match current filters combination",
+  "show_all": "Show all nodes"
 }

src/containers/Storage/StorageNodes/i18n/ru.json

@@ -1,6 +1,8 @@
 {
-    "empty.default": "Нет узлов",
-    "empty.out_of_space": "Нет узлов, в которых кончается место",
-    "empty.degraded": "Нет деградировавших узлов",
-    "show_all": "Показать все узлы"
+  "empty.default": "Нет узлов",
+  "empty.out_of_space": "Нет узлов, в которых кончается место",
+  "empty.degraded": "Нет деградировавших узлов",
+  "empty.small_uptime": "Нет узлов с uptime < 1h",
+  "empty.several_filters": "Нет узлов, подходящих под текущие фильтры",
+  "show_all": "Показать все узлы"
 }