Skip to content

Commit 7310b9f

Browse files
Copilotastandrik
andcommitted
fix: address critical issues from code review - fix error state bug, remove CSS conflicts, and use proper i18n
Co-authored-by: astandrik <[email protected]>
1 parent ef82c22 commit 7310b9f

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/components/ProgressViewer/ProgressViewer.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {useTheme} from '@gravity-ui/uikit';
22

33
import {cn} from '../../utils/cn';
4+
import {EMPTY_DATA_PLACEHOLDER} from '../../utils/constants';
45
import {calculateProgressStatus, defaultFormatProgressValues} from '../../utils/progress';
56
import type {FormatProgressViewerValues} from '../../utils/progress';
67
import {isNumeric} from '../../utils/utils';
@@ -105,5 +106,5 @@ export function ProgressViewer({
105106
);
106107
}
107108

108-
return <div className={`${b({size})} ${className} error`}>no data</div>;
109+
return <div className={b({size, width}, className)}>{EMPTY_DATA_PLACEHOLDER}</div>;
109110
}

src/components/nodesColumns/columns.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,13 @@ export function getMemoryColumn<
208208
<MemoryViewer
209209
formatValues={formatStorageValuesToGb}
210210
stats={row.MemoryStats}
211-
width="full"
212211
/>
213212
) : (
214213
<ProgressViewer
215214
value={row.MemoryUsed}
216215
capacity={row.MemoryLimit}
217216
formatValues={formatStorageValuesToGb}
218217
colorizeProgress={true}
219-
width="full"
220218
/>
221219
);
222220
},

0 commit comments

Comments
 (0)