Skip to content

Commit 79585cd

Browse files
committed
fix
1 parent dd18a22 commit 79585cd

File tree

3 files changed

+25
-23
lines changed

3 files changed

+25
-23
lines changed

src/containers/Tenant/Diagnostics/TopicData/TopicData.tsx

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ export function TopicData({parentRef, path, database}: TopicDataProps) {
5353
const [controlsKey, setControlsKey] = React.useState(0);
5454
const [emptyData, setEmptyData] = React.useState(false);
5555

56-
const [baseOffset, setBaseOffset] = React.useState<number>(0);
57-
const [baseEndOffset, setBaseEndOffset] = React.useState<number>(0);
56+
const [baseOffset, setBaseOffset] = React.useState<number>();
57+
const [baseEndOffset, setBaseEndOffset] = React.useState<number>();
5858

5959
const startRef = React.useRef<number>();
6060
startRef.current = startOffset;
@@ -242,20 +242,22 @@ export function TopicData({parentRef, path, database}: TopicDataProps) {
242242
return (
243243
<React.Fragment>
244244
<FullValue value={fullValue} onClose={() => setFullValue(undefined)} />
245-
<ResizeablePaginatedTable
246-
columnsWidthLSKey={TOPIC_DATA_COLUMNS_WIDTH_LS_KEY}
247-
parentRef={parentRef}
248-
columns={columnsToShow}
249-
fetchData={getTopicData}
250-
initialEntitiesCount={baseEndOffset - baseOffset}
251-
limit={TOPIC_DATA_FETCH_LIMIT}
252-
renderControls={renderControls}
253-
renderErrorMessage={renderPaginatedTableErrorMessage}
254-
renderEmptyDataMessage={renderEmptyDataMessage}
255-
filters={tableFilters}
256-
tableName="topicData"
257-
rowHeight={DEFAULT_TABLE_ROW_HEIGHT}
258-
/>
245+
{!isNil(baseOffset) && !isNil(baseEndOffset) && (
246+
<ResizeablePaginatedTable
247+
columnsWidthLSKey={TOPIC_DATA_COLUMNS_WIDTH_LS_KEY}
248+
parentRef={parentRef}
249+
columns={columnsToShow}
250+
fetchData={getTopicData}
251+
initialEntitiesCount={baseEndOffset - baseOffset}
252+
limit={TOPIC_DATA_FETCH_LIMIT}
253+
renderControls={renderControls}
254+
renderErrorMessage={renderPaginatedTableErrorMessage}
255+
renderEmptyDataMessage={renderEmptyDataMessage}
256+
filters={tableFilters}
257+
tableName="topicData"
258+
rowHeight={DEFAULT_TABLE_ROW_HEIGHT}
259+
/>
260+
)}
259261
</React.Fragment>
260262
);
261263
}

src/containers/Tenant/Diagnostics/TopicData/__test__/getData.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@ describe('prepareResponse', () => {
3636
expect(result.messages.length).toBe(8); // 5 removed + 3 actual
3737

3838
// Check removed messages
39-
expect(result.messages[0]).toEqual({Offset: 'Offset 100 removed'});
40-
expect(result.messages[1]).toEqual({Offset: 'Offset 101 removed'});
41-
expect(result.messages[2]).toEqual({Offset: 'Offset 102 removed'});
42-
expect(result.messages[3]).toEqual({Offset: 'Offset 103 removed'});
43-
expect(result.messages[4]).toEqual({Offset: 'Offset 104 removed'});
39+
expect(result.messages[0]).toEqual({Offset: '<removed> 100'});
40+
expect(result.messages[1]).toEqual({Offset: '<removed> 101'});
41+
expect(result.messages[2]).toEqual({Offset: '<removed> 102'});
42+
expect(result.messages[3]).toEqual({Offset: '<removed> 103'});
43+
expect(result.messages[4]).toEqual({Offset: '<removed> 104'});
4444

4545
// Check actual messages
4646
expect(result.messages[5]).toEqual({Offset: '105'});
@@ -64,7 +64,7 @@ describe('prepareResponse', () => {
6464

6565
// All messages should be "removed" placeholders since there are more than the limit
6666
for (let i = 0; i < TOPIC_DATA_FETCH_LIMIT; i++) {
67-
expect(result.messages[i]).toEqual({Offset: `Offset ${100 + i} removed`});
67+
expect(result.messages[i]).toEqual({Offset: `<removed> ${100 + i}`});
6868
}
6969
});
7070

src/containers/Tenant/Diagnostics/TopicData/getData.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function prepareResponse(response: TopicDataResponse, offset: number) {
2626
const result = [];
2727
for (let i = 0; i < Math.min(TOPIC_DATA_FETCH_LIMIT, removedMessagesCount); i++) {
2828
result.push({
29-
Offset: `Offset ${offset + i} removed`,
29+
Offset: `<removed> ${offset + i}`,
3030
});
3131
}
3232
for (

0 commit comments

Comments
 (0)