Skip to content

Commit 7f027c2

Browse files
fix: review fixes
1 parent 0466072 commit 7f027c2

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/containers/Clusters/columns.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,25 +58,23 @@ function getTitleColumn({isEditClusterAvailable, isDeleteClusterAvailable}: Clus
5858
const renderActions = () => {
5959
const menuItems: (DropdownMenuItem | DropdownMenuItem[])[] = [];
6060

61-
if (isEditClusterAvailable) {
61+
const {onEditCluster, onDeleteCluster} = uiFactory;
62+
63+
if (isEditClusterAvailable && onEditCluster) {
6264
menuItems.push({
6365
text: i18n('edit-cluster'),
6466
iconStart: <Pencil />,
6567
action: () => {
66-
uiFactory.onEditCluster?.({
67-
clusterData: row,
68-
});
68+
onEditCluster({clusterData: row});
6969
},
7070
});
7171
}
72-
if (isDeleteClusterAvailable) {
72+
if (isDeleteClusterAvailable && onDeleteCluster) {
7373
menuItems.push({
7474
text: i18n('remove-cluster'),
7575
iconStart: <TrashBin />,
7676
action: () => {
77-
uiFactory.onDeleteCluster?.({
78-
clusterData: row,
79-
});
77+
onDeleteCluster({clusterData: row});
8078
},
8179
className: b('remove-cluster'),
8280
});

src/containers/Header/Header.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
justify-content: space-between;
55
align-items: center;
66

7-
padding: 0 20px;
7+
padding: 0 var(--g-spacing-5);
88

99
border-bottom: 1px solid var(--g-color-line-generic);
1010

0 commit comments

Comments
 (0)