fix: fix disks developer UI links for paths with nodeId (#594)

Author: artemmufazalov

src/containers/Node/NodeStructure/Pdisk.tsx

@@ -16,7 +16,10 @@ import {bytesToGB} from '../../../utils/utils';
 import {formatStorageValuesToGb} from '../../../utils/dataFormatters/dataFormatters';
 import {getPDiskType} from '../../../utils/pdisk';
 import {DEFAULT_TABLE_SETTINGS} from '../../../utils/constants';
-import {createPDiskDeveloperUILink, createVDiskDeveloperUILink} from '../../../utils/developerUI';
+import {
+    createPDiskDeveloperUILink,
+    createVDiskDeveloperUILink,
+} from '../../../utils/developerUI/developerUI';
 import EntityStatus from '../../../components/EntityStatus/EntityStatus';
 import InfoViewer, {type InfoViewerItem} from '../../../components/InfoViewer/InfoViewer';
 import {ProgressViewer} from '../../../components/ProgressViewer/ProgressViewer';

src/utils/developerUI.ts

@@ -0,0 +1,50 @@
+import {
+    createDeveloperUILinkWithNodeId,
+    createPDiskDeveloperUILink,
+    createVDiskDeveloperUILink,
+} from '../developerUI';
+
+describe('Developer UI links generators', () => {
+    describe('createDeveloperUILinkWithNodeId', () => {
+        it('should create relative link with no host', () => {
+            expect(createDeveloperUILinkWithNodeId(1)).toBe('/node/1/');
+        });
+        it('should create relative link with existing relative path with nodeId', () => {
+            expect(createDeveloperUILinkWithNodeId(1, '/node/3/')).toBe('/node/1/');
+        });
+        it('should create full link with host', () => {
+            expect(
+                createDeveloperUILinkWithNodeId(
+                    1,
+                    'http://ydb-vla-dev02-001.search.yandex.net:8765',
+                ),
+            ).toBe('http://ydb-vla-dev02-001.search.yandex.net:8765/node/1/');
+        });
+        it('should create full link with host with existing node path with nodeId', () => {
+            expect(
+                createDeveloperUILinkWithNodeId(
+                    1,
+                    'http://ydb-vla-dev02-001.search.yandex.net:8765/node/3',
+                ),
+            ).toBe('http://ydb-vla-dev02-001.search.yandex.net:8765/node/1/');
+        });
+    });
+    describe('createPDiskDeveloperUILink', () => {
+        it('should create link with pDiskId and nodeId', () => {
+            expect(createPDiskDeveloperUILink({nodeId: 1, pDiskId: 1})).toBe(
+                '/node/1/actors/pdisks/pdisk000000001',
+            );
+        });
+    });
+    describe('createVDiskDeveloperUILink', () => {
+        it('should create link with pDiskId, vDiskSlotId nodeId', () => {
+            expect(
+                createVDiskDeveloperUILink({
+                    nodeId: 1,
+                    pDiskId: 1,
+                    vDiskSlotId: 1,
+                }),
+            ).toBe('/node/1/actors/vdisks/vdisk000000001_000000001');
+        });
+    });
+});

src/utils/developerUI/__test__/developerUI.test.ts

@@ -0,0 +1,42 @@
+import {backend} from '../../store';
+import {pad9} from '../utils';
+
+// Current node connects with target node by itself using nodeId
+export const createDeveloperUILinkWithNodeId = (nodeId: number | string, host = backend) => {
+    const nodePathRegexp = /\/node\/\d+\/?$/g;
+
+    // In case current backend is already relative node path ({host}/node/{nodeId})
+    // We replace existing nodeId path with new nodeId path
+    if (nodePathRegexp.test(String(host))) {
+        return String(host).replace(nodePathRegexp, `/node/${nodeId}/`);
+    }
+
+    return `${host ?? ''}/node/${nodeId}/`;
+};
+
+interface PDiskDeveloperUILinkParams {
+    nodeId: number | string;
+    pDiskId: number | string;
+    host?: string;
+}
+
+export const createPDiskDeveloperUILink = ({nodeId, pDiskId, host}: PDiskDeveloperUILinkParams) => {
+    const pdiskPath = 'actors/pdisks/pdisk' + pad9(pDiskId);
+
+    return createDeveloperUILinkWithNodeId(nodeId, host) + pdiskPath;
+};
+
+interface VDiskDeveloperUILinkParams extends PDiskDeveloperUILinkParams {
+    vDiskSlotId: number | string;
+}
+
+export const createVDiskDeveloperUILink = ({
+    nodeId,
+    pDiskId,
+    vDiskSlotId,
+    host,
+}: VDiskDeveloperUILinkParams) => {
+    const vdiskPath = 'actors/vdisks/vdisk' + pad9(pDiskId) + '_' + pad9(vDiskSlotId);
+
+    return createDeveloperUILinkWithNodeId(nodeId, host) + vdiskPath;
+};