fix: more explicit code

Author: astandrik

src/containers/Tenant/Diagnostics/TenantOverview/MetricsCards/MetricsCards.tsx

@@ -13,6 +13,10 @@ import {cn} from '../../../../../utils/cn';
 import {SHOW_NETWORK_UTILIZATION} from '../../../../../utils/constants';
 import {useSetting, useTypedSelector} from '../../../../../utils/hooks';
 import {calculateMetricAggregates} from '../../../../../utils/metrics';
+import {
+    formatCoresLegend,
+    formatStorageLegend,
+} from '../../../../../utils/metrics/formatMetricLegend';
 import {TenantTabsGroups, getTenantPath} from '../../../TenantPages';
 import {TabCard} from '../TabCard/TabCard';
 import i18n from '../i18n';
@@ -86,7 +90,7 @@ export function MetricsCards({
                         sublabel={i18n('context_cpu-load')}
                         value={cpuMetrics.totalUsed}
                         limit={cpuMetrics.totalLimit}
-                        unit="cores"
+                        legendFormatter={formatCoresLegend}
                         active={metricsTab === TENANT_METRICS_TABS_IDS.cpu}
                         helpText={i18n('context_cpu-description')}
                     />
@@ -103,7 +107,7 @@ export function MetricsCards({
                         sublabel={i18n('context_storage-groups', {count: storageGroupCount})}
                         value={storageMetrics.totalUsed}
                         limit={storageMetrics.totalLimit}
-                        unit="bytes"
+                        legendFormatter={formatStorageLegend}
                         active={metricsTab === TENANT_METRICS_TABS_IDS.storage}
                         helpText={i18n('context_storage-description')}
                     />
@@ -120,7 +124,7 @@ export function MetricsCards({
                         sublabel={i18n('context_memory-used')}
                         value={memoryMetrics.totalUsed}
                         limit={memoryMetrics.totalLimit}
-                        unit="bytes"
+                        legendFormatter={formatStorageLegend}
                         active={metricsTab === TENANT_METRICS_TABS_IDS.memory}
                         helpText={i18n('context_memory-description')}
                     />
@@ -134,7 +138,7 @@ export function MetricsCards({
                             sublabel={i18n('context_network-evaluation')}
                             value={networkMetrics.totalUsed}
                             limit={networkMetrics.totalLimit}
-                            unit="bytes"
+                            legendFormatter={formatStorageLegend}
                             active={false}
                             clickable={false}
                             helpText={i18n('context_network-description')}

src/containers/Tenant/Diagnostics/TenantOverview/TabCard/TabCard.tsx

@@ -3,10 +3,6 @@ import {Card, Flex} from '@gravity-ui/uikit';
 import {DoughnutMetrics} from '../../../../../components/DoughnutMetrics/DoughnutMetrics';
 import {getDiagramValues} from '../../../../../containers/Cluster/ClusterOverview/utils';
 import {cn} from '../../../../../utils/cn';
-import {
-    formatCoresLegend,
-    formatStorageLegend,
-} from '../../../../../utils/metrics/formatMetricLegend';
 
 import './TabCard.scss';
 
@@ -17,24 +13,22 @@ interface TabCardProps {
     sublabel?: string;
     value: number;
     limit: number;
-    unit: 'bytes' | 'cores';
     active?: boolean;
     helpText?: string;
     clickable?: boolean;
+    legendFormatter: (params: {value: number; capacity: number}) => string;
 }
 
 export function TabCard({
     label,
     sublabel,
     value,
     limit,
-    unit,
     active,
     helpText,
     clickable = true,
+    legendFormatter,
 }: TabCardProps) {
-    const legendFormatter = unit === 'bytes' ? formatStorageLegend : formatCoresLegend;
-
     const {status, percents, legend, fill} = getDiagramValues({
         value,
         capacity: limit,