feat(Navigation): remove legacy navigation setting support

Author: artemmufazalov

src/containers/AsideNavigation/AsideNavigation.tsx

@@ -1,4 +1,4 @@
-import React, {useEffect, useState} from 'react';
+import React, {useState} from 'react';
 import {connect} from 'react-redux';
 import {useLocation} from 'react-router';
 import {useHistory} from 'react-router-dom';
@@ -170,16 +170,6 @@ function AsideNavigation(props: AsideNavigationProps) {
         props.setSettingValue(ASIDE_HEADER_COMPACT_KEY, JSON.stringify(compact));
     };
 
-    // navigation managed its compact state internally before, and its approach is not compatible with settings
-    // to migrate, save the incoming value again; save only `false` because `true` is the default value
-    // assume it is safe to remove this code block if it is at least a few months old
-    // there a two of these, search for a similar comment
-    useEffect(() => {
-        if (props.compact === false) {
-            setIsCompact(props.compact);
-        }
-    }, []); // eslint-disable-line react-hooks/exhaustive-deps
-
     const menuItems: AsideHeaderMenuItem[] = React.useMemo(() => {
         const {pathname} = location;
         const isClusterPage = pathname === '/cluster';

src/store/reducers/settings.js

@@ -26,16 +26,6 @@ export function readSavedSettingsValue(key, defaultValue) {
     return savedValue ?? defaultValue;
 }
 
-// navigation managed its compact state internally before, and its approach is not compatible with settings
-// try reading the old localStorage entry to use it as a default value, for backward compatibility
-// assume it is safe to remove this code block if it is at least a few months old
-// there a two of these, search for a similar comment
-let legacyAsideNavCompactState = '';
-try {
-    legacyAsideNavCompactState = String(JSON.parse(getValueFromLS('nvAsideHeader')).isCompact);
-    localStorage.removeItem('nvAsideHeader');
-} catch {}
-
 export const initialState = {
     problemFilter: ALL,
     userSettings: {
@@ -53,10 +43,7 @@ export const initialState = {
         [SAVED_QUERIES_KEY]: readSavedSettingsValue(SAVED_QUERIES_KEY, '[]'),
         [TENANT_INITIAL_TAB_KEY]: readSavedSettingsValue(TENANT_INITIAL_TAB_KEY),
         [QUERY_INITIAL_MODE_KEY]: readSavedSettingsValue(QUERY_INITIAL_MODE_KEY, QueryModes.script),
-        [ASIDE_HEADER_COMPACT_KEY]: readSavedSettingsValue(
-            ASIDE_HEADER_COMPACT_KEY,
-            legacyAsideNavCompactState || 'true',
-        ),
+        [ASIDE_HEADER_COMPACT_KEY]: readSavedSettingsValue(ASIDE_HEADER_COMPACT_KEY, 'true'),
         [PARTITIONS_SELECTED_COLUMNS_KEY]: readSavedSettingsValue(PARTITIONS_SELECTED_COLUMNS_KEY),
     },
     systemSettings,