Skip to content

Commit 8915093

Browse files
committed
fix: fixes
1 parent 98c5610 commit 8915093

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

src/containers/Tenant/Diagnostics/TopQueries/RunningQueriesData.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ interface Props {
2424
export const RunningQueriesData = ({database, onRowClick, rowClassName}: Props) => {
2525
const [autoRefreshInterval] = useAutoRefreshInterval();
2626
const filters = useTypedSelector((state) => state.executeTopQueries);
27-
const {currentData, isFetching, error} = topQueriesApi.useGetRunningQueriesQuery(
27+
const {currentData, isLoading, error} = topQueriesApi.useGetRunningQueriesQuery(
2828
{
2929
database,
3030
filters,
@@ -41,7 +41,7 @@ export const RunningQueriesData = ({database, onRowClick, rowClassName}: Props)
4141
return (
4242
<React.Fragment>
4343
{error ? <ResponseError error={parseQueryErrorToString(error)} /> : null}
44-
<TableWithControlsLayout.Table loading={isFetching && !data.length}>
44+
<TableWithControlsLayout.Table loading={isLoading}>
4545
<ResizeableDataTable
4646
emptyDataMessage={i18n('no-data')}
4747
columnsWidthLSKey={RUNNING_QUERIES_COLUMNS_WIDTH_LS_KEY}

src/containers/Tenant/Diagnostics/TopQueries/TopQueriesData.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ interface Props {
2222
export const TopQueriesData = ({database, onRowClick, rowClassName}: Props) => {
2323
const [autoRefreshInterval] = useAutoRefreshInterval();
2424
const filters = useTypedSelector((state) => state.executeTopQueries);
25-
const {currentData, isFetching, error} = topQueriesApi.useGetTopQueriesQuery(
25+
const {currentData, isLoading, error} = topQueriesApi.useGetTopQueriesQuery(
2626
{
2727
database,
2828
filters,
@@ -44,7 +44,7 @@ export const TopQueriesData = ({database, onRowClick, rowClassName}: Props) => {
4444
return (
4545
<React.Fragment>
4646
{error ? <ResponseError error={parseQueryErrorToString(error)} /> : null}
47-
<TableWithControlsLayout.Table loading={isFetching && currentData === undefined}>
47+
<TableWithControlsLayout.Table loading={isLoading}>
4848
<ResizeableDataTable
4949
emptyDataMessage={i18n('no-data')}
5050
columnsWidthLSKey={TOP_QUERIES_COLUMNS_WIDTH_LS_KEY}

src/store/reducers/executeTopQueries/executeTopQueries.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ export const topQueriesApi = api.injectEndpoints({
9898
? `Query ILIKE '%${filters.text}%' OR UserSID ILIKE '%${filters.text}%'`
9999
: '';
100100

101-
const commonQueryPart = `SELECT UserSID, QueryStartAt, Query as QueryText, ApplicationName from \`.sys/query_sessions\` WHERE ${filterConditions || 'true'}`;
102-
103-
const queryText = `${commonQueryPart} AND Query NOT LIKE '${commonQueryPart}%' ORDER BY SessionStartAt limit 100`;
101+
const queryText = `SELECT UserSID, QueryStartAt, Query as QueryText, ApplicationName from \`.sys/query_sessions\` WHERE ${filterConditions || 'true'} ORDER BY SessionStartAt limit 100`;
104102

105103
const response = await window.api.sendQuery(
106104
{
@@ -117,6 +115,13 @@ export const topQueriesApi = api.injectEndpoints({
117115

118116
const data = parseQueryAPIExecuteResponse(response);
119117

118+
/* filter running queries query itself */
119+
if (data?.resultSets?.[0]?.result) {
120+
data.resultSets[0].result = data.resultSets[0].result.filter(
121+
(item) => item.QueryText !== queryText,
122+
);
123+
}
124+
120125
return {data};
121126
} catch (error) {
122127
return {error};

0 commit comments

Comments
 (0)