feat: paginated tables - enable setting by default (#1464)

Author: astandrik

src/services/settings.ts

@@ -36,7 +36,7 @@ export const DEFAULT_USER_SETTINGS = {
     [LAST_USED_QUERY_ACTION_KEY]: QUERY_ACTIONS.execute,
     [ASIDE_HEADER_COMPACT_KEY]: true,
     [PARTITIONS_HIDDEN_COLUMNS_KEY]: [],
-    [USE_PAGINATED_TABLES_KEY]: false,
+    [USE_PAGINATED_TABLES_KEY]: true,
     [USE_CLUSTER_BALANCER_AS_BACKEND_KEY]: true,
     [ENABLE_AUTOCOMPLETE]: true,
     [AUTOCOMPLETE_ON_ENTER]: true,

tests/suites/nodes/NodesPage.ts

@@ -2,14 +2,13 @@ import type {Locator, Page} from '@playwright/test';
 
 import {PageModel} from '../../models/PageModel';
 import {nodesPage} from '../../utils/constants';
-import {selectContentTable} from '../../utils/selectContentTable';
 
 export class NodesPage extends PageModel {
     readonly table: Locator;
 
     constructor(page: Page) {
         super(page, nodesPage);
 
-        this.table = selectContentTable(this.selector);
+        this.table = this.selector.locator('.ydb-paginated-table__table');
     }
 }

tests/suites/storage/StoragePage.ts

@@ -2,32 +2,24 @@ import type {Locator, Page} from '@playwright/test';
 
 import {PageModel} from '../../models/PageModel';
 import {storagePage} from '../../utils/constants';
-import {selectContentTable} from '../../utils/selectContentTable';
 
 type EntityType = 'Groups' | 'Nodes';
-type VisibleEntityType = 'Degraded' | 'Out of space' | 'All';
 
 const storageTypeFilterQa = 'storage-type-filter';
-const storageVisibleEntitiesFilterQa = 'storage-visible-entities-filter';
 
 export class StoragePage extends PageModel {
     readonly table: Locator;
     protected readonly entityTypeSelector: Locator;
-    protected readonly visibleEntityTypeSelector: Locator;
 
     constructor(page: Page) {
         super(page, storagePage);
 
-        this.table = selectContentTable(this.selector);
+        this.table = this.selector.locator('.ydb-paginated-table__table');
 
         this.entityTypeSelector = this.selector.getByTestId(storageTypeFilterQa);
-        this.visibleEntityTypeSelector = this.selector.getByTestId(storageVisibleEntitiesFilterQa);
     }
 
     async selectEntityType(type: EntityType) {
         await this.entityTypeSelector.getByLabel(type).click();
     }
-    async selectVisibleEntityType(type: VisibleEntityType) {
-        await this.visibleEntityTypeSelector.getByLabel(type).click();
-    }
 }

tests/suites/storage/storage.test.ts

@@ -15,7 +15,6 @@ test.describe('Test Storage page', async () => {
         const storagePage = new StoragePage(page);
         await storagePage.goto();
 
-        await storagePage.selectVisibleEntityType('All');
         await storagePage.selectEntityType('Groups');
 
         await expect(storagePage.table).toBeVisible();
@@ -25,7 +24,6 @@ test.describe('Test Storage page', async () => {
         const storagePage = new StoragePage(page);
         await storagePage.goto();
 
-        await storagePage.selectVisibleEntityType('All');
         await storagePage.selectEntityType('Nodes');
 
         await expect(storagePage.table).toBeVisible();