fix: copilot review 2

Author: artemmufazalov

src/components/VersionsBar/VersionsBar.tsx

@@ -11,12 +11,16 @@ import './VersionsBar.scss';
 
 const b = cn('ydb-versions-bar');
 
+const TRUNCATION_THRESHOLD = 4;
+// One more line for Show more / Hide button
+const MAX_DISPLAYED_VERSIONS = TRUNCATION_THRESHOLD - 1;
+
 interface VersionsBarProps {
     preparedVersions: PreparedVersion[];
 }
 
 export function VersionsBar({preparedVersions}: VersionsBarProps) {
-    const shouldTruncateVersions = preparedVersions.length > 4;
+    const shouldTruncateVersions = preparedVersions.length > TRUNCATION_THRESHOLD;
 
     const [hoveredVersion, setHoveredVersion] = React.useState<string | undefined>();
     const [allVersionsDisplayed, setAllVersionsDisplayed] = React.useState<boolean>(false);
@@ -39,7 +43,9 @@ export function VersionsBar({preparedVersions}: VersionsBarProps) {
             return preparedVersions;
         }
 
-        return shouldTruncateVersions ? preparedVersions.slice(0, 3) : preparedVersions;
+        return shouldTruncateVersions
+            ? preparedVersions.slice(0, MAX_DISPLAYED_VERSIONS)
+            : preparedVersions;
     }, [allVersionsDisplayed, preparedVersions, shouldTruncateVersions]);
 
     const handleShowAllVersions = (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
@@ -55,7 +61,7 @@ export function VersionsBar({preparedVersions}: VersionsBarProps) {
 
     const renderButton = () => {
         if (shouldTruncateVersions) {
-            const truncatedVersionsCount = preparedVersions.length - 3;
+            const truncatedVersionsCount = preparedVersions.length - MAX_DISPLAYED_VERSIONS;
 
             if (allVersionsDisplayed) {
                 return (

src/utils/versions/__test__/sortVerions.test.ts renamed to src/utils/versions/__test__/sortVersions.test.ts

@@ -74,7 +74,7 @@ export const prepareClusterVersions = (
 
     filteredVersions.forEach((item) => {
         if (result[item.version]) {
-            // Summ count for versions of different nodes types
+            // Sum count for versions of different nodes types
             const currentCount = result[item.version].count || 0;
             const itemCount = item.count || 0;
 

src/utils/versions/clusterVersionColors.ts

@@ -4,7 +4,8 @@ import type {PreparedVersion} from './types';
 /**
  * Sorts cluster versions according to the following rules:
  * 1. First by majorIndex in ascending order (lower index first)
- * - Higher version numbers typically have lower indices (e.g., v3.0.0: index 0, v2.0.0: index 1, v1.0.0: index 2)
+ * - In embedded versions higher version numbers typically have lower indices (e.g., v3.0.0: index 0, v2.0.0: index 1, v1.0.0: index 2)
+ * - In multi-cluster version indices may be provided by backend with no specific rule, but we use the same sorting for consistency
  * - Versions with undefined majorIndex come last
  * 2. Then by minorIndex in ascending order (lower index first) when majorIndex is the same
  * - Higher minor versions typically have lower indices