fix: move to script

Author: github-actions[bot]

.github/workflows/quality.yml

@@ -229,193 +229,13 @@ jobs:
 
       - name: Update PR description
         uses: actions/github-script@v6
+        env:
+          CURRENT_SIZE: ${{ needs.bundle_size.outputs.current_size }}
+          MAIN_SIZE: ${{ needs.bundle_size.outputs.main_size }}
+          SIZE_DIFF: ${{ needs.bundle_size.outputs.diff }}
+          SIZE_PERCENT: ${{ needs.bundle_size.outputs.percent }}
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}
           script: |
-            const fs = require('fs');
-            const testResultsPath = 'playwright-artifacts/test-results.json';
-            const mainTestResultsPath = 'gh-pages/main/test-results.json';
-            let testResults;
-            let mainTestResults;
-            let testComparison = {
-              new: [],
-              skipped: [],
-              deleted: []
-            };
-
-            // Helper function to extract all tests from a suite recursively
-            function extractTestsFromSuite(suite, parentTitle = '') {
-              let tests = [];
-              const fullSuiteTitle = parentTitle ? `${parentTitle} > ${suite.title}` : suite.title;
-              
-              if (suite.specs) {
-                tests.push(...suite.specs.map(spec => {
-                  const isSkipped = spec.tests && spec.tests[0] && 
-                    (spec.tests[0].annotations?.some(a => a.type === 'skip') || 
-                     spec.tests[0].status === 'skipped');
-                  
-                  return {
-                    title: spec.title,
-                    fullTitle: `${fullSuiteTitle} > ${spec.title}`,
-                    status: isSkipped ? 'skipped' : (spec.ok ? 'passed' : 'failed'),
-                    file: suite.file,
-                    skipped: isSkipped
-                  };
-                }));
-              }
-              
-              // Recursively process nested suites
-              if (suite.suites) {
-                suite.suites.forEach(nestedSuite => {
-                  tests.push(...extractTestsFromSuite(nestedSuite, fullSuiteTitle));
-                });
-              }
-              
-              return tests;
-            }
-
-            // Read current PR test results
-            if (fs.existsSync(testResultsPath)) {
-              const rawData = fs.readFileSync(testResultsPath);
-              const data = JSON.parse(rawData);
-              const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
-              
-              testResults = {
-                total: data.stats.expected + data.stats.unexpected + data.stats.flaky + data.stats.skipped,
-                passed: data.stats.expected,
-                failed: data.stats.unexpected,
-                flaky: data.stats.flaky,
-                skipped: data.stats.skipped,
-                tests: allTests
-              };
-            } else {
-              console.log('Test results file not found');
-              testResults = { total: 0, passed: 0, failed: 0, flaky: 0, skipped: 0, tests: [] };
-            }
-
-            // Read main branch test results
-            if (fs.existsSync(mainTestResultsPath)) {
-              const rawData = fs.readFileSync(mainTestResultsPath);
-              const data = JSON.parse(rawData);
-              const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
-              mainTestResults = { tests: allTests };
-
-              // Compare tests
-              const currentTests = new Map(testResults.tests.map(t => [t.fullTitle, t]));
-              const mainTests = new Map(mainTestResults.tests.map(t => [t.fullTitle, t]));
-
-              // Find new tests
-              for (const [fullTitle, test] of currentTests) {
-                if (!mainTests.has(fullTitle)) {
-                  testComparison.new.push(`${test.title} (${test.file})`);
-                }
-              }
-
-              // Find deleted tests
-              for (const [fullTitle, test] of mainTests) {
-                if (!currentTests.has(fullTitle)) {
-                  testComparison.deleted.push(`${test.title} (${test.file})`);
-                }
-              }
-
-              // Find skipped tests (both newly skipped and already skipped)
-              testComparison.skipped = testResults.tests
-                .filter(t => t.skipped)
-                .map(test => `${test.title} (${test.file})`);
-
-              testComparison.skipped = Array.from(new Set(testComparison.skipped));
-            } else {
-              console.log('Main branch test results file not found');
-              mainTestResults = { tests: [] };
-            }
-
-            const reportUrl = `https://${context.repo.owner}.github.io/${context.repo.repo}/${context.issue.number}/`;
-            const status = testResults.failed > 0 ? '❌ FAILED' : (testResults.flaky > 0 ? '⚠️ FLAKY' : '✅ PASSED');
-            const statusColor = testResults.failed > 0 ? 'red' : (testResults.flaky > 0 ? 'orange' : 'green');
-
-            const currentSize = parseInt('${{ needs.bundle_size.outputs.current_size }}');
-            const mainSize = parseInt('${{ needs.bundle_size.outputs.main_size }}');
-            const diff = parseInt('${{ needs.bundle_size.outputs.diff }}');
-            const percent = '${{ needs.bundle_size.outputs.percent }}';
-
-            const formatSize = (size) => {
-              if (size >= 1024) {
-                return `${(size / (1024 * 1024)).toFixed(2)} MB`;
-              }
-              return `${(size / 1024).toFixed(2)} KB`;
-            };
-
-            const bundleStatus = percent === 'N/A' ? '⚠️' :
-                                parseFloat(percent) > 0 ? '🔺' :
-                                parseFloat(percent) < 0 ? '🔽' : '✅';
-
-            // Generate test changes summary based on actual changes
-            let testChangesSummary = '😟 No changes in tests. 😕';
-            if (testComparison.new.length > 0 || testComparison.deleted.length > 0 || testComparison.skipped.length > 0) {
-              testChangesSummary = `
-              <details>
-              <summary>Test Changes Summary ${testComparison.new.length > 0 ? `✨${testComparison.new.length} ` : ''}${testComparison.skipped.length > 0 ? `⏭️${testComparison.skipped.length} ` : ''}${testComparison.deleted.length > 0 ? `🗑️${testComparison.deleted.length}` : ''}</summary>
-
-              ${testComparison.new.length > 0 ? `#### ✨ New Tests (${testComparison.new.length})
-              ${testComparison.new.map((test, i) => `${i + 1}. ${test}`).join('\n')}
-
-              ` : ''}${testComparison.skipped.length > 0 ? `#### ⏭️ Skipped Tests (${testComparison.skipped.length})
-              ${testComparison.skipped.map((test, i) => `${i + 1}. ${test}`).join('\n')}
-
-              ` : ''}${testComparison.deleted.length > 0 ? `#### 🗑️ Deleted Tests (${testComparison.deleted.length})
-              ${testComparison.deleted.map((test, i) => `${i + 1}. ${test}`).join('\n')}` : ''}
-              </details>`;
-            }
-
-            const ciSection = `## CI Results
-
-            ### Test Status: <span style="color: ${statusColor};">${status}</span>
-            📊 [Full Report](${reportUrl})
-
-            | Total | Passed | Failed | Flaky | Skipped |
-            |:-----:|:------:|:------:|:-----:|:-------:|
-            | ${testResults.total} | ${testResults.passed} | ${testResults.failed} | ${testResults.flaky} | ${testResults.skipped} |
-
-            ${testChangesSummary}
-
-            ### Bundle Size: ${bundleStatus}
-            Current: ${formatSize(currentSize)} | Main: ${formatSize(mainSize)}
-            Diff: ${diff > 0 ? '+' : ''}${formatSize(Math.abs(diff))} (${percent === 'N/A' ? 'N/A' : `${percent}%`})
-
-            ${
-              percent === 'N/A' ? '⚠️ Unable to calculate change.' :
-              parseFloat(percent) > 0 ? '⚠️ Bundle size increased. Please review.' :
-              parseFloat(percent) < 0 ? '✅ Bundle size decreased.' : '✅ Bundle size unchanged.'
-            }
-
-            <details>
-            <summary>ℹ️ CI Information</summary>
-
-            - Test recordings for failed tests are available in the full report.
-            - Bundle size is measured for the entire 'dist' directory.
-            - 📊 indicates links to detailed reports.
-            - 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.
-            </details>`;
-
-            const { data: pullRequest } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.issue.number,
-            });
-
-            const currentBody = pullRequest.body || '';
-            const ciSectionRegex = /## CI Results[\s\S]*?(?=\n## (?!CI Results)|$)/;
-
-            let newBody = currentBody;
-            if (ciSectionRegex.test(newBody)) {
-              newBody = newBody.replace(ciSectionRegex, ciSection);
-            } else {
-              newBody += '\n\n' + ciSection;
-            }
-
-            await github.rest.pulls.update({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: context.issue.number,
-              body: newBody,
-            });
+            const updatePRDescription = require('./.github/workflows/scripts/update-pr-description.js');
+            await updatePRDescription(github, context);

.github/workflows/scripts/update-pr-description.js

@@ -0,0 +1,193 @@
+const fs = require('fs');
+
+// Helper function to extract all tests from a suite recursively
+function extractTestsFromSuite(suite, parentTitle = '') {
+  let tests = [];
+  const fullSuiteTitle = parentTitle ? `${parentTitle} > ${suite.title}` : suite.title;
+  
+  if (suite.specs) {
+    tests.push(...suite.specs.map(spec => {
+      const isSkipped = spec.tests && spec.tests[0] && 
+        (spec.tests[0].annotations?.some(a => a.type === 'skip') || 
+         spec.tests[0].status === 'skipped');
+      
+      return {
+        title: spec.title,
+        fullTitle: `${fullSuiteTitle} > ${spec.title}`,
+        status: isSkipped ? 'skipped' : (spec.ok ? 'passed' : 'failed'),
+        file: suite.file,
+        skipped: isSkipped
+      };
+    }));
+  }
+  
+  // Recursively process nested suites
+  if (suite.suites) {
+    suite.suites.forEach(nestedSuite => {
+      tests.push(...extractTestsFromSuite(nestedSuite, fullSuiteTitle));
+    });
+  }
+  
+  return tests;
+}
+
+function formatSize(size) {
+  if (size >= 1024) {
+    return `${(size / (1024 * 1024)).toFixed(2)} MB`;
+  }
+  return `${(size / 1024).toFixed(2)} KB`;
+}
+
+async function updatePRDescription(github, context) {
+  const testResultsPath = 'playwright-artifacts/test-results.json';
+  const mainTestResultsPath = 'gh-pages/main/test-results.json';
+  let testResults;
+  let mainTestResults;
+  let testComparison = {
+    new: [],
+    skipped: [],
+    deleted: []
+  };
+
+  // Read current PR test results
+  if (fs.existsSync(testResultsPath)) {
+    const rawData = fs.readFileSync(testResultsPath);
+    const data = JSON.parse(rawData);
+    const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
+    
+    testResults = {
+      total: data.stats.expected + data.stats.unexpected + data.stats.flaky + data.stats.skipped,
+      passed: data.stats.expected,
+      failed: data.stats.unexpected,
+      flaky: data.stats.flaky,
+      skipped: data.stats.skipped,
+      tests: allTests
+    };
+  } else {
+    console.log('Test results file not found');
+    testResults = { total: 0, passed: 0, failed: 0, flaky: 0, skipped: 0, tests: [] };
+  }
+
+  // Read main branch test results
+  if (fs.existsSync(mainTestResultsPath)) {
+    const rawData = fs.readFileSync(mainTestResultsPath);
+    const data = JSON.parse(rawData);
+    const allTests = data.suites.flatMap(suite => extractTestsFromSuite(suite));
+    mainTestResults = { tests: allTests };
+
+    // Compare tests
+    const currentTests = new Map(testResults.tests.map(t => [t.fullTitle, t]));
+    const mainTests = new Map(mainTestResults.tests.map(t => [t.fullTitle, t]));
+
+    // Find new tests
+    for (const [fullTitle, test] of currentTests) {
+      if (!mainTests.has(fullTitle)) {
+        testComparison.new.push(`${test.title} (${test.file})`);
+      }
+    }
+
+    // Find deleted tests
+    for (const [fullTitle, test] of mainTests) {
+      if (!currentTests.has(fullTitle)) {
+        testComparison.deleted.push(`${test.title} (${test.file})`);
+      }
+    }
+
+    // Find skipped tests (both newly skipped and already skipped)
+    testComparison.skipped = testResults.tests
+      .filter(t => t.skipped)
+      .map(test => `${test.title} (${test.file})`);
+
+    testComparison.skipped = Array.from(new Set(testComparison.skipped));
+  } else {
+    console.log('Main branch test results file not found');
+    mainTestResults = { tests: [] };
+  }
+
+  const reportUrl = `https://${context.repo.owner}.github.io/${context.repo.repo}/${context.issue.number}/`;
+  const status = testResults.failed > 0 ? '❌ FAILED' : (testResults.flaky > 0 ? '⚠️ FLAKY' : '✅ PASSED');
+  const statusColor = testResults.failed > 0 ? 'red' : (testResults.flaky > 0 ? 'orange' : 'green');
+
+  // Get bundle size information from environment variables
+  const currentSize = parseInt(process.env.CURRENT_SIZE || '0');
+  const mainSize = parseInt(process.env.MAIN_SIZE || '0');
+  const diff = parseInt(process.env.SIZE_DIFF || '0');
+  const percent = process.env.SIZE_PERCENT || 'N/A';
+
+  const bundleStatus = percent === 'N/A' ? '⚠️' :
+                      parseFloat(percent) > 0 ? '🔺' :
+                      parseFloat(percent) < 0 ? '🔽' : '✅';
+
+  // Generate test changes summary based on actual changes
+  let testChangesSummary = '😟 No changes in tests. 😕';
+  if (testComparison.new.length > 0 || testComparison.deleted.length > 0 || testComparison.skipped.length > 0) {
+    testChangesSummary = `
+    <details>
+    <summary>Test Changes Summary ${testComparison.new.length > 0 ? `✨${testComparison.new.length} ` : ''}${testComparison.skipped.length > 0 ? `⏭️${testComparison.skipped.length} ` : ''}${testComparison.deleted.length > 0 ? `🗑️${testComparison.deleted.length}` : ''}</summary>
+
+    ${testComparison.new.length > 0 ? `#### ✨ New Tests (${testComparison.new.length})
+    ${testComparison.new.map((test, i) => `${i + 1}. ${test}`).join('\n')}
+
+    ` : ''}${testComparison.skipped.length > 0 ? `#### ⏭️ Skipped Tests (${testComparison.skipped.length})
+    ${testComparison.skipped.map((test, i) => `${i + 1}. ${test}`).join('\n')}
+
+    ` : ''}${testComparison.deleted.length > 0 ? `#### 🗑️ Deleted Tests (${testComparison.deleted.length})
+    ${testComparison.deleted.map((test, i) => `${i + 1}. ${test}`).join('\n')}` : ''}
+    </details>`;
+  }
+
+  const ciSection = `## CI Results
+
+  ### Test Status: <span style="color: ${statusColor};">${status}</span>
+  📊 [Full Report](${reportUrl})
+
+  | Total | Passed | Failed | Flaky | Skipped |
+  |:-----:|:------:|:------:|:-----:|:-------:|
+  | ${testResults.total} | ${testResults.passed} | ${testResults.failed} | ${testResults.flaky} | ${testResults.skipped} |
+
+  ${testChangesSummary}
+
+  ### Bundle Size: ${bundleStatus}
+  Current: ${formatSize(currentSize)} | Main: ${formatSize(mainSize)}
+  Diff: ${diff > 0 ? '+' : ''}${formatSize(Math.abs(diff))} (${percent === 'N/A' ? 'N/A' : `${percent}%`})
+
+  ${
+    percent === 'N/A' ? '⚠️ Unable to calculate change.' :
+    parseFloat(percent) > 0 ? '⚠️ Bundle size increased. Please review.' :
+    parseFloat(percent) < 0 ? '✅ Bundle size decreased.' : '✅ Bundle size unchanged.'
+  }
+
+  <details>
+  <summary>ℹ️ CI Information</summary>
+
+  - Test recordings for failed tests are available in the full report.
+  - Bundle size is measured for the entire 'dist' directory.
+  - 📊 indicates links to detailed reports.
+  - 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.
+  </details>`;
+
+  const { data: pullRequest } = await github.rest.pulls.get({
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    pull_number: context.issue.number,
+  });
+
+  const currentBody = pullRequest.body || '';
+  const ciSectionRegex = /## CI Results[\s\S]*?(?=\n## (?!CI Results)|$)/;
+
+  let newBody = currentBody;
+  if (ciSectionRegex.test(newBody)) {
+    newBody = newBody.replace(ciSectionRegex, ciSection);
+  } else {
+    newBody += '\n\n' + ciSection;
+  }
+
+  await github.rest.pulls.update({
+    owner: context.repo.owner,
+    repo: context.repo.repo,
+    pull_number: context.issue.number,
+    body: newBody,
+  });
+}
+
+module.exports = updatePRDescription;