fix: disable restart for followers and remove duplicate tooltip (#3036)

Author: DaryaVorontsova

src/components/ButtonWithConfirmDialog/ButtonWithConfirmDialog.tsx

@@ -15,7 +15,6 @@ interface ButtonWithConfirmDialogProps<T, K> {
     retryButtonText?: string;
     buttonDisabled?: ButtonProps['disabled'];
     buttonView?: ButtonProps['view'];
-    buttonTitle?: ButtonProps['title'];
     buttonClassName?: ButtonProps['className'];
     withPopover?: boolean;
     popoverContent?: PopoverProps['content'];
@@ -32,7 +31,6 @@ export function ButtonWithConfirmDialog<T, K>({
     retryButtonText,
     buttonDisabled = false,
     buttonView = 'action',
-    buttonTitle,
     buttonClassName,
     withPopover = false,
     popoverContent,
@@ -71,13 +69,13 @@ export function ButtonWithConfirmDialog<T, K>({
                 disabled={buttonDisabled}
                 loading={!buttonDisabled && buttonLoading}
                 className={buttonClassName}
-                title={buttonTitle}
             >
                 {children}
             </Button>
         );
     };
 
+    // keep <span>: if button is disabled, popover won't open without this wrapper
     const renderContent = () => {
         if (withPopover) {
             return (
@@ -86,7 +84,7 @@ export function ButtonWithConfirmDialog<T, K>({
                     placement={popoverPlacement}
                     disabled={popoverDisabled}
                 >
-                    {renderButton()}
+                    <span>{renderButton()}</span>
                 </Popover>
             );
         }

src/containers/Tablets/TabletsTable.tsx

@@ -25,6 +25,10 @@ import {useIsUserAllowedToMakeChanges} from '../../utils/hooks/useIsUserAllowedT
 
 import i18n from './i18n';
 
+function isFollowerTablet(state: TTabletStateInfo) {
+    return state.Leader === false;
+}
+
 function getColumns({nodeId}: {nodeId?: string | number}) {
     const columns: DataTableColumn<TTabletStateInfo & {fqdn?: string}>[] = [
         {
@@ -34,7 +38,7 @@ function getColumns({nodeId}: {nodeId?: string | number}) {
                 return i18n('Type');
             },
             render: ({row}) => {
-                const isFollower = row.Leader === false;
+                const isFollower = isFollowerTablet(row);
                 return (
                     <span>
                         {row.Type} {isFollower ? <Text color="secondary">follower</Text> : ''}
@@ -138,7 +142,8 @@ function getColumns({nodeId}: {nodeId?: string | number}) {
 }
 
 function TabletActions(tablet: TTabletStateInfo) {
-    const isDisabledRestart = tablet.State === ETabletState.Stopped;
+    const isFollower = isFollowerTablet(tablet);
+    const isDisabledRestart = tablet.State === ETabletState.Stopped || isFollower;
     const isUserAllowedToMakeChanges = useIsUserAllowedToMakeChanges();
     const [killTablet] = tabletApi.useKillTabletMutation();
 
@@ -147,22 +152,27 @@ function TabletActions(tablet: TTabletStateInfo) {
         return null;
     }
 
+    let popoverContent: React.ReactNode;
+
+    if (isFollower) {
+        popoverContent = i18n('controls.kill-impossible-follower');
+    } else if (!isUserAllowedToMakeChanges) {
+        popoverContent = i18n('controls.kill-not-allowed');
+    } else {
+        popoverContent = i18n('dialog.kill-header');
+    }
+
     return (
         <ButtonWithConfirmDialog
             buttonView="outlined"
-            buttonTitle={i18n('dialog.kill-header')}
             dialogHeader={i18n('dialog.kill-header')}
             dialogText={i18n('dialog.kill-text')}
             onConfirmAction={() => {
                 return killTablet({id}).unwrap();
             }}
             buttonDisabled={isDisabledRestart || !isUserAllowedToMakeChanges}
             withPopover
-            popoverContent={
-                isUserAllowedToMakeChanges
-                    ? i18n('dialog.kill-header')
-                    : i18n('controls.kill-not-allowed')
-            }
+            popoverContent={popoverContent}
             popoverPlacement={['right', 'bottom']}
             popoverDisabled={false}
         >

src/containers/Tablets/i18n/en.json

@@ -10,6 +10,7 @@
   "dialog.kill-header": "Restart tablet",
   "dialog.kill-text": "The tablet will be restarted. Do you want to proceed?",
   "controls.kill-not-allowed": "You don't have enough rights to restart tablet",
+  "controls.kill-impossible-follower": "It's impossible to restart a follower",
   "controls.search-placeholder": "Tablet ID",
   "controls.entities-count-label": "Tablets"
 }