fix: code-review

Author: Raubzeug

src/containers/Tenant/ObjectSummary/__test__/transformPath.test.ts

@@ -1,4 +1,5 @@
-import {transformPath} from '../transformPath';
+import {EPathType} from '../../../../types/api/schema';
+import {isDomain, transformPath} from '../transformPath';
 
 describe('transformPath', () => {
     test.each([
@@ -41,3 +42,32 @@ describe('transformPath', () => {
         expect(transformPath('///dev/v1/sth', '/dev')).toBe('v1/sth');
     });
 });
+
+describe('isDomain', () => {
+    it('should return true for valid domain paths', () => {
+        expect(isDomain('/domain', EPathType.EPathTypeDir)).toBe(true);
+        expect(isDomain('/another-domain', EPathType.EPathTypeDir)).toBe(true);
+    });
+
+    it('should return false for non-directory paths', () => {
+        expect(isDomain('/domain', EPathType.EPathTypeColumnStore)).toBe(false);
+        expect(isDomain('/domain', undefined)).toBe(false);
+    });
+
+    it('should return false for paths without slash', () => {
+        expect(isDomain('domain', EPathType.EPathTypeDir)).toBe(false);
+    });
+
+    it('should return false for paths with multiple slashes', () => {
+        expect(isDomain('/domain/subdomain', EPathType.EPathTypeDir)).toBe(false);
+        expect(isDomain('/domain/', EPathType.EPathTypeDir)).toBe(false);
+    });
+
+    it('should return false for empty paths', () => {
+        expect(isDomain('', EPathType.EPathTypeDir)).toBe(false);
+    });
+
+    it('should return true for root path', () => {
+        expect(isDomain('/', EPathType.EPathTypeDir)).toBe(true);
+    });
+});

src/containers/Tenant/ObjectSummary/transformPath.ts

@@ -24,14 +24,5 @@ export function isDomain(path: string, type?: EPathType) {
     if (type !== EPathType.EPathTypeDir) {
         return false;
     }
-    let count = 0;
-    for (let i = 0; i <= path.length; i++) {
-        if (path[i] === '/') {
-            count++;
-        }
-        if (count > 1) {
-            return false;
-        }
-    }
-    return count === 1;
+    return path.split('/').length === 2 && path.startsWith('/');
 }