fix: review fixes

Author: astandrik

src/containers/Cluster/ClusterOverview/ClusterOverview.tsx

@@ -1,3 +1,5 @@
+import React from 'react';
+
 import {ArrowToggle, Disclosure, Flex, Icon, Text} from '@gravity-ui/uikit';
 
 import {ResponseError} from '../../../components/Errors/ResponseError';
@@ -105,7 +107,7 @@ function ClusterDoughnuts({cluster, groupStats = {}, loading, collapsed}: Cluste
     if (loading) {
         return <ClusterDashboardSkeleton collapsed={collapsed} />;
     }
-    const metricsCards = [] as React.ReactNode[];
+    const metricsCards: React.ReactNode[] = [];
     if (isClusterInfoV2(cluster)) {
         const {CoresUsed, NumberOfCpus, CoresTotal} = cluster;
         const total = CoresTotal ?? NumberOfCpus;
@@ -160,5 +162,3 @@ function ClusterDoughnuts({cluster, groupStats = {}, loading, collapsed}: Cluste
 
     return metricsCards;
 }
-
-//

src/containers/Nodes/Nodes.tsx

@@ -68,7 +68,7 @@ export function Nodes({
         }
 
         const pileColumn = getPileNameColumn<NodesPreparedEntity>();
-        // Type trick above is irrelevant at runtime; cast to any and enhance with sortable
+        // Add sortable flag consistently with other columns using nodesColumns constants
         const enhancedPileColumn = {
             ...pileColumn,
             sortable: isSortableNodesColumn(NODES_COLUMNS_IDS.PileName),

src/containers/Versions/NodesTable/NodesTable.tsx

@@ -11,22 +11,31 @@ import {
     getUptimeColumn,
 } from '../../../components/nodesColumns/columns';
 import type {GetNodesColumnsParams} from '../../../components/nodesColumns/types';
+import {useBridgeModeEnabled} from '../../../store/reducers/capabilities/hooks';
 import type {NodesPreparedEntity} from '../../../store/reducers/nodes/types';
 import {DEFAULT_TABLE_SETTINGS} from '../../../utils/constants';
 import {useAdditionalNodesProps} from '../../../utils/hooks/useAdditionalNodesProps';
 
 const VERSIONS_COLUMNS_WIDTH_LS_KEY = 'versionsTableColumnsWidth';
 
-function getColumns(params: GetNodesColumnsParams): Column<NodesPreparedEntity>[] {
-    return [
+function getColumns(
+    params: GetNodesColumnsParams,
+    includePileName: boolean,
+): Column<NodesPreparedEntity>[] {
+    const cols: Column<NodesPreparedEntity>[] = [
         getNodeIdColumn<NodesPreparedEntity>(),
         getHostColumn<NodesPreparedEntity>(params),
-        getPileNameColumn<NodesPreparedEntity>(),
+    ];
+    if (includePileName) {
+        cols.push(getPileNameColumn<NodesPreparedEntity>());
+    }
+    cols.push(
         getUptimeColumn<NodesPreparedEntity>(),
         getRAMColumn<NodesPreparedEntity>(),
         getCpuColumn<NodesPreparedEntity>(),
         getLoadAverageColumn<NodesPreparedEntity>(),
-    ];
+    );
+    return cols;
 }
 
 interface NodesTableProps {
@@ -35,8 +44,9 @@ interface NodesTableProps {
 
 export const NodesTable = ({nodes}: NodesTableProps) => {
     const additionalNodesProps = useAdditionalNodesProps();
+    const bridgeModeEnabled = useBridgeModeEnabled();
 
-    const columns = getColumns({getNodeRef: additionalNodesProps?.getNodeRef});
+    const columns = getColumns({getNodeRef: additionalNodesProps?.getNodeRef}, bridgeModeEnabled);
 
     return (
         <ResizeableDataTable

tests/suites/bridge/mocks.ts

@@ -24,7 +24,19 @@ export const mockNodesWithPile = (page: Page) => {
             body: JSON.stringify({
                 FoundNodes: 1,
                 TotalNodes: 1,
-                Nodes: [{NodeId: 1, SystemState: {}, PileName: 'r1'}],
+                Nodes: [
+                    {
+                        NodeId: 1,
+                        SystemState: {
+                            Host: 'localhost',
+                            Version: 'test-version',
+                            LoadAverage: [0.1, 0.1, 0.1],
+                            NumberOfCpus: 8,
+                            StartTime: '1',
+                        },
+                        PileName: 'r1',
+                    },
+                ],
             }),
         });
     });