fix(Nodes): default path to node should be Overview

Author: Raubzeug

src/components/PDiskViewer/PDiskViewer.js

@@ -8,6 +8,8 @@ import EntityStatus from '../EntityStatus/EntityStatus';
 import {formatStorageValues} from '../../utils';
 import routes, {createHref} from '../../routes';
 
+import {getDefaultNodePath} from '../../containers/Node/NodePages';
+
 import './PDiskViewer.scss';
 
 const b = cn('pdisk-viewer');
@@ -48,10 +50,7 @@ class PDiskViewer extends React.Component {
                             <EntityStatus
                                 status={'green'}
                                 label="NodeID"
-                                path={createHref(routes.node, {
-                                    id: disk.NodeId,
-                                    activeTab: 'storage',
-                                })}
+                                path={getDefaultNodePath(disk.NodeId)}
                                 name={disk.NodeId}
                             />
                         </div>

src/containers/Node/Node.js

@@ -8,7 +8,7 @@ import {Loader, Tabs} from '@yandex-cloud/uikit';
 import {withRouter, Link} from 'react-router-dom';
 
 import FullNodeViewer from '../../components/FullNodeViewer/FullNodeViewer';
-import {TABLETS, STORAGE, NODE_PAGES} from './NodePages';
+import {TABLETS, STORAGE, NODE_PAGES, OVERVIEW} from './NodePages';
 import Tablets from '../Tablets/Tablets';
 import Storage from '../Storage/Storage';
 
@@ -69,7 +69,7 @@ class Node extends React.Component {
         if (node) {
             const hasStorage = _.find(node.Roles, (el) => el === STORAGE_ROLE);
             if (!hasStorage) {
-                activeTab = TABLETS;
+                activeTab = OVERVIEW;
             }
             this.setState((prev) => {
                 if (prev.activeTab !== activeTab) {

src/containers/Node/NodePages.js

@@ -1,7 +1,14 @@
+import routes, {createHref} from '../../routes';
+
 export const STORAGE = 'storage';
 export const TABLETS = 'tablets';
+export const OVERVIEW = 'overview';
 
 export const NODE_PAGES = [
+    {
+        id: OVERVIEW,
+        name: 'Overview',
+    },
     {
         id: STORAGE,
         name: 'Storage',
@@ -11,3 +18,10 @@ export const NODE_PAGES = [
         name: 'Tablets',
     },
 ];
+
+export function getDefaultNodePath(nodeId) {
+    return createHref(routes.node, {
+        id: nodeId,
+        activeTab: OVERVIEW,
+    });
+}

src/containers/Pdisk/Pdisk.js

@@ -14,7 +14,7 @@ import ProgressViewer from '../../components/ProgressViewer/ProgressViewer';
 import {getPdiskInfo, clearStore} from '../../store/reducers/pdisk';
 import {PDISK_AUTO_RELOAD_INTERVAL} from '../../utils/constants';
 import {formatStorageValues, calcUptime} from '../../utils';
-import routes, {createHref} from '../../routes';
+import {getDefaultNodePath} from '../Node/NodePages';
 
 import './Pdisk.scss';
 
@@ -97,10 +97,7 @@ class Pdisk extends React.Component {
             {
                 label: 'NodeId',
                 value: (
-                    <Link
-                        className={b('link')}
-                        to={createHref(routes.node, {id: NodeId, activeTab: 'storage'})}
-                    >
+                    <Link className={b('link')} to={getDefaultNodePath(NodeId)}>
                         {NodeId}
                     </Link>
                 ),

src/containers/Tablet/Tablet.js

@@ -19,6 +19,7 @@ import {Link as ExternalLink, Button, Loader} from '@yandex-cloud/uikit';
 import DataTable from '@yandex-cloud/react-data-table';
 import CriticalActionDialog from '../../components/CriticalActionDialog/CriticalActionDialog';
 import routes, {createHref} from '../../routes';
+import { getDefaultNodePath } from '../Node/NodePages';
 
 import './Tablet.scss';
 
@@ -316,13 +317,7 @@ class Tablet extends React.Component {
             {
                 label: 'Node',
                 value: (
-                    <Link
-                        className={b('link')}
-                        to={createHref(routes.node, {
-                            id: String(tablet.NodeId),
-                            activeTab: 'storage',
-                        })}
-                    >
+                    <Link className={b('link')} to={getDefaultNodePath(String(tablet.NodeId))}>
                         {tablet.NodeId}
                     </Link>
                 ),

src/containers/Tenant/Diagnostics/Network/Network.js

@@ -14,11 +14,11 @@ import ProblemFilter, {problemFilterType} from '../../../../components/ProblemFi
 import {getNetworkInfo} from '../../../../store/reducers/network';
 import {hideTooltip, showTooltip} from '../../../../store/reducers/tooltip';
 import {ALL, PROBLEMS} from '../../../../utils/constants';
-import routes, {createHref} from '../../../../routes';
 import {changeFilter} from '../../../../store/reducers/settings';
+import {AutoFetcher} from '../../../../utils/autofetcher';
+import {getDefaultNodePath} from '../../../Node/NodePages';
 
 import './Network.scss';
-import {AutoFetcher} from '../../../../utils/autofetcher';
 
 const b = cn('network');
 
@@ -301,10 +301,7 @@ class Network extends React.Component {
                                         Connectivity of node{' '}
                                         <Link
                                             className={b('link')}
-                                            to={createHref(routes.node, {
-                                                id: clickedNode.NodeId,
-                                                activeTab: 'storage',
-                                            })}
+                                            to={getDefaultNodePath(clickedNode.NodeId)}
                                         >
                                             {clickedNode.NodeId}
                                         </Link>{' '}

src/containers/Vdisk/Vdisk.js

@@ -13,6 +13,7 @@ import {getVdiskInfo, clearStore} from '../../store/reducers/vdisk';
 import {VDISK_AUTO_RELOAD_INTERVAL} from '../../utils/constants';
 import {formatBytes, calcUptime, stringifyVdiskId} from '../../utils';
 import routes, {createHref} from '../../routes';
+import {getDefaultNodePath} from '../Node/NodePages';
 
 import './Vdisk.scss';
 
@@ -80,10 +81,7 @@ class Vdisk extends React.Component {
             {
                 label: 'NodeId',
                 value: (
-                    <Link
-                        className={b('link')}
-                        to={createHref(routes.node, {id: NodeId, activeTab: 'storage'})}
-                    >
+                    <Link className={b('link')} to={getDefaultNodePath(NodeId)}>
                         {NodeId}
                     </Link>
                 ),

src/containers/VdiskPdiskNode/VdiskPdiskNode.js

@@ -20,6 +20,7 @@ import {getNodeInfo} from '../../store/reducers/node';
 import {calcUptime, stringifyVdiskId, formatStorageValuesToGb} from '../../utils';
 import routes, {createHref} from '../../routes';
 import {bytesToSpeed, bytesToGB} from '../../utils/utils';
+import {getDefaultNodePath} from '../Node/NodePages';
 
 import './VdiskPdiskNode.scss';
 
@@ -329,10 +330,7 @@ class VdiskPdiskNode extends React.Component {
             {
                 label: 'Node Id',
                 value: (
-                    <Link
-                        className={b('link')}
-                        to={createHref(routes.node, {id: NodeId, activeTab: 'storage'})}
-                    >
+                    <Link className={b('link')} to={getDefaultNodePath(NodeId)}>
                         {NodeId}
                     </Link>
                 ),

src/utils/getNodesColumns.js

@@ -6,13 +6,11 @@ import {Button, Tooltip} from '@yandex-cloud/uikit';
 
 import Icon from '../components/Icon/Icon';
 import EntityStatus from '../components/EntityStatus/EntityStatus';
-import {STORAGE_ROLE} from '../containers/Node/Node';
 import PoolsGraph from '../components/PoolsGraph/PoolsGraph';
 import ProgressViewer from '../components/ProgressViewer/ProgressViewer';
 import TabletsStatistic from '../components/TabletsStatistic/TabletsStatistic';
 
-import routes, {createHref} from '../routes';
-import {STORAGE, TABLETS} from '../containers/Node/NodePages';
+import {getDefaultNodePath} from '../containers/Node/NodePages';
 import {formatBytes} from './index';
 
 const b = cn('kv-nodes');
@@ -28,7 +26,6 @@ export function getNodesColumns({showTooltip, hideTooltip, tabletsPath, getNodeR
         {
             name: 'Host',
             render: ({row, value}) => {
-                const hasStorage = _.find(row?.Roles, (el) => el === STORAGE_ROLE);
                 const nodeRef = getNodeRef ? getNodeRef(row) : undefined;
 
                 if (typeof value === 'undefined') {
@@ -39,10 +36,7 @@ export function getNodesColumns({showTooltip, hideTooltip, tabletsPath, getNodeR
                         <EntityStatus
                             name={row.Host}
                             status={row.Overall}
-                            path={createHref(routes.node, {
-                                id: row.NodeId,
-                                activeTab: hasStorage ? STORAGE : TABLETS,
-                            })}
+                            path={getDefaultNodePath(row.NodeId)}
                             hasClipboardButton
                             className={b('host-name')}
                         />