fix: better checks

Author: astandrik

tests/suites/tenant/summary/ObjectSummary.ts

@@ -1,5 +1,6 @@
 import type {Locator, Page} from '@playwright/test';
 
+import {isInViewport} from '../../../utils/dom';
 import {VISIBILITY_TIMEOUT} from '../TenantPage';
 
 import {ActionsMenu} from './ActionsMenu';
@@ -28,6 +29,7 @@ export class ObjectSummary {
     private infoExpandButton: Locator;
     private summaryCollapseButton: Locator;
     private summaryExpandButton: Locator;
+    private overviewWrapper: Locator;
 
     constructor(page: Page) {
         this.tree = page.locator('.ydb-object-summary__tree');
@@ -59,6 +61,7 @@ export class ObjectSummary {
         this.summaryExpandButton = page.locator(
             '.ydb-object-summary__actions button[title="Expand"]',
         );
+        this.overviewWrapper = page.locator('.ydb-object-summary__overview-wrapper');
     }
 
     async collapseInfoPanel(): Promise<void> {
@@ -70,8 +73,19 @@ export class ObjectSummary {
     }
 
     async isInfoPanelCollapsed(): Promise<boolean> {
-        // When panel is collapsed, expand button should be visible
-        return this.infoExpandButton.isVisible();
+        const expandButtonVisible = await this.infoExpandButton.isVisible();
+        if (!expandButtonVisible) {
+            return false;
+        }
+
+        const isVisible = await this.overviewWrapper.isVisible();
+        if (!isVisible) {
+            return true;
+        }
+
+        // Check if it's actually in the viewport
+        const elementInViewport = await isInViewport(this.overviewWrapper);
+        return !elementInViewport;
     }
 
     async isCreateDirectoryModalVisible(): Promise<boolean> {
@@ -242,7 +256,18 @@ export class ObjectSummary {
     }
 
     async isSummaryCollapsed(): Promise<boolean> {
-        // When summary is collapsed, expand button should be visible
-        return this.summaryExpandButton.isVisible();
+        const expandButtonVisible = await this.summaryExpandButton.isVisible();
+        if (!expandButtonVisible) {
+            return false;
+        }
+
+        const isVisible = await this.tree.isVisible();
+        if (!isVisible) {
+            return true;
+        }
+
+        // Check if it's actually in the viewport
+        const elementInViewport = await isInViewport(this.tree);
+        return !elementInViewport;
     }
 }

tests/utils/dom.ts

@@ -0,0 +1,18 @@
+import type {Locator} from '@playwright/test';
+
+/**
+ * Checks if an element is within the viewport
+ * @param locator - Playwright locator for the element to check
+ * @returns Promise<boolean> - true if the element is within viewport bounds
+ */
+export const isInViewport = async (locator: Locator): Promise<boolean> => {
+    return locator.evaluate((el) => {
+        const rect = el.getBoundingClientRect();
+        return (
+            rect.top >= 0 &&
+            rect.left >= 0 &&
+            rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
+            rect.right <= (window.innerWidth || document.documentElement.clientWidth)
+        );
+    });
+};