Skip to content

Commit b3d38ae

Browse files
fix: copilot review
1 parent 1defcf7 commit b3d38ae

File tree

3 files changed

+30
-6
lines changed

3 files changed

+30
-6
lines changed

src/containers/Versions/groupNodes.test.ts

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,50 +10,74 @@ const nodes: PreparedStorageNode[] = [
1010
NodeId: 1,
1111
Version: '25-1-1',
1212
Roles: ['StateStorageBoard', 'SchemeBoard', 'Bootstrapper', 'StateStorage', 'Storage'],
13+
Missing: 0,
14+
MaximumSlotsPerDisk: 0,
15+
MaximumDisksPerNode: 0,
1316
},
1417
{
1518
// Storage node
1619
NodeId: 2,
1720
Version: '25-1-2',
1821
Roles: ['Storage'],
22+
Missing: 0,
23+
MaximumSlotsPerDisk: 0,
24+
MaximumDisksPerNode: 0,
1925
},
2026
{
2127
// Storage node
2228
NodeId: 3,
2329
Version: '25-1-3',
2430
Roles: ['Storage'],
31+
Missing: 0,
32+
MaximumSlotsPerDisk: 0,
33+
MaximumDisksPerNode: 0,
2534
},
2635
{
2736
// Tenant node
2837
NodeId: 4,
2938
Version: '25-1-1',
3039
Roles: ['Tenant'],
3140
Tenants: ['/Root/db1'],
41+
Missing: 0,
42+
MaximumSlotsPerDisk: 0,
43+
MaximumDisksPerNode: 0,
3244
},
3345
{
3446
// Tenant node
3547
NodeId: 5,
3648
Version: '25-1-2',
3749
Roles: ['Tenant'],
3850
Tenants: ['/Root/db2'],
51+
Missing: 0,
52+
MaximumSlotsPerDisk: 0,
53+
MaximumDisksPerNode: 0,
3954
},
4055
{
4156
// Tenant node without Roles
4257
NodeId: 6,
4358
Version: '25-1-3',
4459
Tenants: ['/Root/db3'],
60+
Missing: 0,
61+
MaximumSlotsPerDisk: 0,
62+
MaximumDisksPerNode: 0,
4563
},
4664
{
4765
// Node with some other role
4866
NodeId: 7,
4967
Version: '25-1-1',
5068
Roles: ['Bootstrapper'],
69+
Missing: 0,
70+
MaximumSlotsPerDisk: 0,
71+
MaximumDisksPerNode: 0,
5172
},
5273
{
5374
// Node without roles
5475
NodeId: 8,
5576
Version: '25-1-1',
5677
Roles: [],
78+
Missing: 0,
79+
MaximumSlotsPerDisk: 0,
80+
MaximumDisksPerNode: 0,
5781
},
5882
];
5983

src/store/reducers/storage/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ export interface PreparedStorageNode
3636
VDisks?: PreparedVDisk[];
3737
Tablets?: TTabletStateInfo[];
3838

39-
Missing?: number;
40-
MaximumSlotsPerDisk?: number;
41-
MaximumDisksPerNode?: number;
39+
Missing: number;
40+
MaximumSlotsPerDisk: number;
41+
MaximumDisksPerNode: number;
4242
}
4343

4444
export interface PreparedStorageGroupFilters {

src/store/reducers/storage/utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,20 +207,20 @@ const prepareStorageNodeData = (
207207
const pDisks = PDisks?.map((pDisk) => {
208208
return {
209209
...prepareWhiteboardPDiskData(pDisk),
210-
NodeId: node.NodeId,
210+
NodeId,
211211
};
212212
});
213213
const vDisks = VDisks?.map((vDisk) => {
214214
return {
215215
...prepareWhiteboardVDiskData(vDisk),
216-
NodeId: node.NodeId,
216+
NodeId,
217217
};
218218
});
219219

220220
return {
221221
...restNodeParams,
222222
...prepareNodeSystemState(SystemState),
223-
NodeId: NodeId,
223+
NodeId,
224224
PDisks: pDisks,
225225
VDisks: vDisks,
226226
Missing: missing,

0 commit comments

Comments
 (0)