Skip to content

Commit b5811c2

Browse files
committed
fix: better code
1 parent 8f83784 commit b5811c2

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/components/MetricChart/MetricChart.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,6 @@ interface DiagnosticsChartProps {
125125

126126
/** Chart title displayed in the toolbar */
127127
title: string;
128-
129-
/**
130-
* When true, skip fetching chart data completely (no initial request, no polling)
131-
*/
132-
skip?: boolean;
133128
}
134129

135130
export const MetricChart = ({
@@ -143,7 +138,6 @@ export const MetricChart = ({
143138
onChartDataStatusChange,
144139
isChartVisible,
145140
title,
146-
skip,
147141
}: DiagnosticsChartProps) => {
148142
const [timeFrame, setTimeFrame] = React.useState<TimeFrame>(defaultTimeFrame);
149143

@@ -160,7 +154,7 @@ export const MetricChart = ({
160154
timeFrame,
161155
maxDataPoints,
162156
},
163-
{pollingInterval: autorefresh, skip},
157+
{pollingInterval: autorefresh},
164158
);
165159

166160
const loading = isFetching && !currentData;

src/components/QueriesActivityBar/QueriesActivityCharts.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import React from 'react';
33
import {Flex} from '@gravity-ui/uikit';
44

55
import {defaultDashboardConfig} from '../../containers/Tenant/Diagnostics/TenantOverview/DefaultOverviewContent/defaultDashboardConfig';
6-
import {useGraphShardExists} from '../../store/reducers/capabilities/hooks';
76
import {cn} from '../../utils/cn';
87
import {useAutoRefreshInterval} from '../../utils/hooks';
98
import {MetricChart} from '../MetricChart/MetricChart';
@@ -26,7 +25,6 @@ export function QueriesActivityCharts({
2625
expanded,
2726
onChartDataStatusChange,
2827
}: QueriesActivityChartsProps) {
29-
const graphShardExists = useGraphShardExists();
3028
const [autoRefreshInterval] = useAutoRefreshInterval();
3129
const [hasChartsLoaded, setHasChartsLoaded] = React.useState(false);
3230

@@ -86,7 +84,6 @@ export function QueriesActivityCharts({
8684
onChartDataStatusChange={handleChartDataStatusChange}
8785
isChartVisible={hasChartsLoaded && expanded}
8886
title={queriesChartConfig.title}
89-
skip={graphShardExists === false}
9087
/>
9188
</Flex>
9289

@@ -100,7 +97,6 @@ export function QueriesActivityCharts({
10097
onChartDataStatusChange={handleChartDataStatusChange}
10198
isChartVisible={hasChartsLoaded && expanded}
10299
title={latenciesChartConfig.title}
103-
skip={graphShardExists === false}
104100
/>
105101
</Flex>
106102
</Flex>

0 commit comments

Comments
 (0)