Skip to content

Commit c34f669

Browse files
authored
fix: refactor useSavedQueries (#3023)
1 parent 4594a93 commit c34f669

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/containers/Tenant/Query/QueryEditor/helpers.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,10 @@ import type Monaco from 'monaco-editor';
66
import {codeAssistApi} from '../../../../store/reducers/codeAssist/codeAssist';
77
import {selectQueriesHistory} from '../../../../store/reducers/query/query';
88
import type {TelemetryOpenTabs} from '../../../../types/api/codeAssist';
9-
import type {SavedQuery} from '../../../../types/store/query';
10-
import {
11-
AUTOCOMPLETE_ON_ENTER,
12-
ENABLE_AUTOCOMPLETE,
13-
SAVED_QUERIES_KEY,
14-
} from '../../../../utils/constants';
9+
import {AUTOCOMPLETE_ON_ENTER, ENABLE_AUTOCOMPLETE} from '../../../../utils/constants';
1510
import {useSetting, useTypedSelector} from '../../../../utils/hooks';
1611
import {YQL_LANGUAGE_ID} from '../../../../utils/monaco/constats';
12+
import {useSavedQueries} from '../utils/useSavedQueries';
1713

1814
export type EditorOptions = Monaco.editor.IEditorOptions & Monaco.editor.IGlobalEditorOptions;
1915

@@ -50,7 +46,7 @@ export function useCodeAssistHelpers() {
5046
const [ignoreSuggestion] = codeAssistApi.useIgnoreSuggestionMutation();
5147
const [sendUserQueriesData] = codeAssistApi.useSendUserQueriesDataMutation();
5248
const historyQueries = useTypedSelector(selectQueriesHistory);
53-
const [savedQueries] = useSetting<SavedQuery[]>(SAVED_QUERIES_KEY, []);
49+
const savedQueries = useSavedQueries();
5450

5551
const getCodeAssistSuggestions = React.useCallback(
5652
async (promptFiles: PromptFile[]) => sendCodeAssistPrompt(promptFiles).unwrap(),

src/containers/Tenant/Query/SavedQueries/SavedQueries.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {useTypedDispatch, useTypedSelector} from '../../../../utils/hooks';
2424
import {useChangeInputWithConfirmation} from '../../../../utils/hooks/withConfirmation/useChangeInputWithConfirmation';
2525
import {MAX_QUERY_HEIGHT, QUERY_TABLE_SETTINGS} from '../../utils/constants';
2626
import i18n from '../i18n';
27-
import {useSavedQueries} from '../utils/useSavedQueries';
27+
import {useFilteredSavedQueries} from '../utils/useSavedQueries';
2828

2929
import './SavedQueries.scss';
3030

@@ -68,7 +68,7 @@ interface SavedQueriesProps {
6868
}
6969

7070
export const SavedQueries = ({changeUserInput}: SavedQueriesProps) => {
71-
const savedQueries = useSavedQueries();
71+
const savedQueries = useFilteredSavedQueries();
7272
const dispatch = useTypedDispatch();
7373
const filter = useTypedSelector(selectSavedQueriesFilter);
7474

src/containers/Tenant/Query/utils/useSavedQueries.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ import {useSetting, useTypedSelector} from '../../../../utils/hooks';
77

88
export function useSavedQueries() {
99
const [savedQueries] = useSetting<SavedQuery[]>(SAVED_QUERIES_KEY, []);
10+
11+
return savedQueries;
12+
}
13+
14+
export function useFilteredSavedQueries() {
15+
const savedQueries = useSavedQueries();
1016
const filter = useTypedSelector(selectSavedQueriesFilter).trim().toLowerCase();
1117

1218
const filteredSavedQueries = React.useMemo(() => {

0 commit comments

Comments
 (0)