Skip to content

Commit c6d7186

Browse files
committed
fix: loading statuses
1 parent 5de1a3a commit c6d7186

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

src/components/QueryExecutionStatus/QueryExecutionStatus.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,8 @@
11
import React from 'react';
22

3-
import {
4-
CircleCheckFill,
5-
CircleDashed,
6-
CircleQuestionFill,
7-
CircleStop,
8-
CircleXmark,
9-
} from '@gravity-ui/icons';
3+
import {CircleCheckFill, CircleQuestionFill, CircleStop, CircleXmark} from '@gravity-ui/icons';
104
import type {LabelProps, TextProps} from '@gravity-ui/uikit';
11-
import {Icon, Label, Text} from '@gravity-ui/uikit';
5+
import {Icon, Label, Spin, Text} from '@gravity-ui/uikit';
126

137
import {isQueryCancelledError} from '../../containers/Tenant/Query/utils/isQueryCancelledError';
148
import {cn} from '../../utils/cn';
@@ -37,7 +31,7 @@ export const QueryExecutionStatus = ({className, error, loading}: QueryExecution
3731
if (loading) {
3832
theme = 'info';
3933
textColor = 'info-heavy';
40-
icon = <Icon data={CircleDashed} />;
34+
icon = <Spin size="xs" />;
4135
label = 'Running';
4236
} else if (isAxiosError(error) && error.code === 'ECONNABORTED') {
4337
theme = 'danger';

src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22

33
import type {Settings} from '@gravity-ui/react-data-table';
44
import type {ControlGroupOption} from '@gravity-ui/uikit';
5-
import {ClipboardButton, Loader, RadioButton} from '@gravity-ui/uikit';
5+
import {ClipboardButton, RadioButton} from '@gravity-ui/uikit';
66

77
import EnableFullscreenButton from '../../../../components/EnableFullscreenButton/EnableFullscreenButton';
88
import Fullscreen from '../../../../components/Fullscreen/Fullscreen';
@@ -271,7 +271,7 @@ export function QueryResultViewer({
271271
const renderLeftControls = () => {
272272
return (
273273
<div className={b('controls-left')}>
274-
{!error && !isLoading && (
274+
{!error && (
275275
<React.Fragment>
276276
{valueIsDefined(stats?.DurationUs) ? (
277277
<QueryDuration duration={Number(stats.DurationUs)} />
@@ -286,7 +286,6 @@ export function QueryResultViewer({
286286
</React.Fragment>
287287
)}
288288
<QueryExecutionStatus error={error} loading={isLoading} />
289-
{isLoading ? <Loader size="s" /> : null}
290289
{data?.traceId && isExecute ? <TraceButton traceId={data.traceId} /> : null}
291290
</div>
292291
);
@@ -315,7 +314,7 @@ export function QueryResultViewer({
315314
{renderRightControls()}
316315
</div>
317316
{isLoading || isQueryCancelledError(error) ? null : <QuerySettingsBanner />}
318-
<LoaderWrapper loading={isLoading && !data.resultSets}>
317+
<LoaderWrapper loading={isLoading && (!data.resultSets || activeSection !== 'result')}>
319318
<Fullscreen className={b('result')}>{renderResultSection()}</Fullscreen>
320319
</LoaderWrapper>
321320
</React.Fragment>

0 commit comments

Comments
 (0)