fix: review

Author: astandrik

src/containers/Tenant/Query/QueryResult/components/PlanToSvgButton/PlanToSvgButton.tsx

@@ -6,6 +6,7 @@ import {Button, DropdownMenu, Tooltip} from '@gravity-ui/uikit';
 
 import {planToSvgApi} from '../../../../../../store/reducers/planToSvg';
 import type {QueryPlan, ScriptPlan} from '../../../../../../types/api/query';
+import {prepareCommonErrorMessage} from '../../../../../../utils/errors';
 import i18n from '../../i18n';
 
 function getButtonView(error: string | null, isLoading: boolean) {
@@ -40,8 +41,7 @@ export function PlanToSvgButton({plan, database}: PlanToSvgButtonProps) {
                 return url;
             })
             .catch((err) => {
-                const errorMessage = err.data?.message || err.message || JSON.stringify(err);
-                setError(errorMessage);
+                setError(prepareCommonErrorMessage(err));
                 return null;
             });
     }, [database, getPlanToSvg, plan, blobUrl]);

src/types/api/error.ts

@@ -18,7 +18,7 @@ export interface NetworkError {
     description?: unknown;
     fileName?: unknown;
     lineNumber?: unknown;
-    message?: 'Network Error';
+    message: 'Network Error';
     name?: string;
     number?: unknown;
     stack?: string;

src/utils/errors/i18n/en.json

@@ -0,0 +1,3 @@
+{
+  "unknown-error": "An unknown error occurred"
+}

src/utils/errors/i18n/index.ts

@@ -0,0 +1,7 @@
+import {registerKeysets} from '../../i18n';
+
+import en from './en.json';
+
+const COMPONENT = 'ydb-errors';
+
+export default registerKeysets(COMPONENT, {en});

src/utils/errors/index.ts

@@ -0,0 +1,39 @@
+import type {IResponseError} from '../../types/api/error';
+import {isNetworkError} from '../response';
+
+import i18n from './i18n';
+
+/**
+ * Prepares a consistent error message from various error types
+ * @param err - The error object to process
+ * @returns A formatted error message string
+ */
+export function prepareCommonErrorMessage(err: unknown): string {
+    // Handle string errors
+    if (typeof err === 'string') {
+        return err;
+    }
+
+    // Handle null/undefined
+    if (!err) {
+        return i18n('unknown-error');
+    }
+
+    // Handle NetworkError
+    if (isNetworkError(err)) {
+        return err.message;
+    }
+
+    if (typeof err === 'object' && 'data' in err) {
+        const responseError = err as IResponseError;
+        if (responseError.data?.message) {
+            return responseError.data.message;
+        }
+    }
+
+    if (err instanceof Error) {
+        return err.message;
+    }
+
+    return JSON.stringify(err);
+}