Skip to content

Commit d360823

Browse files
committed
fix: better code
1 parent 1c07728 commit d360823

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

src/containers/Operations/Operations.scss

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/containers/Operations/Operations.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ import i18n from './i18n';
1414
import {b} from './shared';
1515
import {useOperationsQueryParams} from './useOperationsQueryParams';
1616

17-
import './Operations.scss';
18-
1917
interface OperationsProps {
2018
database: string;
2119
}

src/containers/Operations/columns.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {duration} from '@gravity-ui/date-utils';
22
import type {Column as DataTableColumn} from '@gravity-ui/react-data-table';
33
import {Text} from '@gravity-ui/uikit';
44

5-
import {EntityStatus} from '../../components/EntityStatus/EntityStatus';
5+
import {CellWithPopover} from '../../components/CellWithPopover/CellWithPopover';
66
import type {TOperation} from '../../types/api/operationList';
77
import {EStatusCode} from '../../types/api/operationList';
88
import {EMPTY_DATA_PLACEHOLDER, HOUR_IN_SECONDS, SECOND_IN_MS} from '../../utils/constants';
@@ -17,12 +17,16 @@ export function getColumns(): DataTableColumn<TOperation>[] {
1717
{
1818
name: COLUMNS_NAMES.ID,
1919
header: COLUMNS_TITLES[COLUMNS_NAMES.ID],
20-
width: 220,
20+
width: 340,
2121
render: ({row}) => {
2222
if (!row.id) {
2323
return EMPTY_DATA_PLACEHOLDER;
2424
}
25-
return <EntityStatus name={row.id} showStatus={false} />;
25+
return (
26+
<CellWithPopover placement={['top', 'bottom']} content={row.id}>
27+
{row.id}
28+
</CellWithPopover>
29+
);
2630
},
2731
},
2832
{

src/containers/Operations/useOperationsQueryParams.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ import {z} from 'zod';
33

44
import type {OperationKind} from '../../types/api/operationList';
55

6-
const operationKindSchema = z
7-
.enum(['ss/backgrounds', 'import', 'export', 'buildindex', 'scriptexec'])
8-
.catch('ss/backgrounds');
6+
const operationKindSchema = z.enum(['ss/backgrounds', 'export', 'buildindex']).catch('buildindex');
97

108
export function useOperationsQueryParams() {
119
const [queryParams, setQueryParams] = useQueryParams({

0 commit comments

Comments
 (0)