fix: review fixes

Author: astandrik

src/components/Errors/ResponseError/ResponseError.tsx

@@ -14,5 +14,5 @@ export const ResponseError = ({
 }: ResponseErrorProps) => {
     const message = prepareErrorMessage(error) || defaultMessage;
 
-    return <div className={`error ${className}`}>{message}</div>;
+    return <div className={`error ${className || ''}`}>{message}</div>;
 };

src/components/ProgressViewer/ProgressViewer.tsx

@@ -140,5 +140,5 @@ export function ProgressViewer({
         );
     }
 
-    return <div className={`${b({size})} ${className} error`}>{i18n('no-data')}</div>;
+    return <div className={`${b({size})} ${className || ''} error`}>{i18n('no-data')}</div>;
 }

src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx

@@ -9,10 +9,9 @@ import {LabelWithPopover} from '../../../../../components/LabelWithPopover';
 import {ProgressViewer} from '../../../../../components/ProgressViewer/ProgressViewer';
 import {parseQuery} from '../../../../../routes';
 import {TENANT_STORAGE_TABS_IDS} from '../../../../../store/reducers/tenant/constants';
-import {setStorageTab} from '../../../../../store/reducers/tenant/tenant';
 import {cn} from '../../../../../utils/cn';
 import {formatStorageValues} from '../../../../../utils/dataFormatters/dataFormatters';
-import {useTypedDispatch, useTypedSelector} from '../../../../../utils/hooks';
+import {useTypedSelector} from '../../../../../utils/hooks';
 import {TenantTabsGroups, getTenantPath} from '../../../TenantPages';
 import {TenantDashboard} from '../TenantDashboard/TenantDashboard';
 import i18n from '../i18n';
@@ -43,20 +42,13 @@ interface TenantStorageProps {
 }
 
 export function TenantStorage({tenantName, metrics}: TenantStorageProps) {
-    const dispatch = useTypedDispatch();
     const location = useLocation();
     const {storageTab = TENANT_STORAGE_TABS_IDS.tables} = useTypedSelector((state) => state.tenant);
 
     const {blobStorageUsed, tabletStorageUsed, blobStorageLimit, tabletStorageLimit} = metrics;
 
     const queryParams = parseQuery(location);
 
-    React.useEffect(() => {
-        if (!storageTab) {
-            dispatch(setStorageTab(TENANT_STORAGE_TABS_IDS.tables));
-        }
-    }, [storageTab, dispatch]);
-
     const renderTabContent = () => {
         switch (storageTab) {
             case TENANT_STORAGE_TABS_IDS.tables:

src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json

@@ -49,4 +49,4 @@
   "title_top-groups-by-usage": "Top Groups By Usage",
   "action_by-load": "By Load",
   "action_by-pool-usage": "By Pool Usage"
-}
+}

src/store/reducers/tenant/tenant.ts

@@ -55,24 +55,27 @@ const slice = createSlice({
         },
         setMetricsTab: (state, action: PayloadAction<TenantMetricsTab>) => {
             // Ensure we always have a valid metrics tab - fallback to CPU if empty/invalid
-            const validTabs = Object.values(TENANT_METRICS_TABS_IDS);
-            const isValidTab = action.payload && validTabs.includes(action.payload as any);
+            const validTabs = Object.values(TENANT_METRICS_TABS_IDS) as TenantMetricsTab[];
+            const isValidTab = action.payload && validTabs.includes(action.payload);
             state.metricsTab = isValidTab ? action.payload : TENANT_METRICS_TABS_IDS.cpu;
         },
         setCpuTab: (state, action: PayloadAction<TenantCpuTab>) => {
             // Ensure we always have a valid cpu tab - fallback to nodes if empty/invalid
-            const validTabs = Object.values(TENANT_CPU_TABS_IDS);
-            const isValidTab = action.payload && validTabs.includes(action.payload as any);
+            const validTabs = Object.values(TENANT_CPU_TABS_IDS) as TenantCpuTab[];
+            const isValidTab = action.payload && validTabs.includes(action.payload);
             state.cpuTab = isValidTab ? action.payload : TENANT_CPU_TABS_IDS.nodes;
         },
         setNodesMode: (state, action: PayloadAction<TenantNodesMode>) => {
             // Ensure we always have a valid nodes mode - fallback to load if empty/invalid
-            const validModes = Object.values(TENANT_CPU_NODES_MODE_IDS);
-            const isValidMode = action.payload && validModes.includes(action.payload as any);
+            const validModes = Object.values(TENANT_CPU_NODES_MODE_IDS) as TenantNodesMode[];
+            const isValidMode = action.payload && validModes.includes(action.payload);
             state.nodesMode = isValidMode ? action.payload : TENANT_CPU_NODES_MODE_IDS.load;
         },
         setStorageTab: (state, action: PayloadAction<TenantStorageTab>) => {
-            state.storageTab = action.payload;
+            // Ensure we always have a valid storage tab - fallback to tables if empty/invalid
+            const validTabs = Object.values(TENANT_STORAGE_TABS_IDS) as TenantStorageTab[];
+            const isValidTab = action.payload && validTabs.includes(action.payload);
+            state.storageTab = isValidTab ? action.payload : TENANT_STORAGE_TABS_IDS.tables;
         },
     },
 });