Skip to content

Commit d5d8b36

Browse files
committed
fix: add subclasses - fix review
1 parent 874caf9 commit d5d8b36

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/containers/Tenant/utils/paneVisibilityToggleHelpers.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ export function PaneVisibilityToggleButtons({
8686
<React.Fragment>
8787
<ActionTooltip title="Collapse">
8888
<Button
89-
title="Collapse"
9089
view="flat-secondary"
9190
onClick={onCollapse}
9291
className={b(
9392
{
9493
hidden: isCollapsed,
94+
type: 'collapse',
9595
},
9696
className,
9797
)}
@@ -102,12 +102,12 @@ export function PaneVisibilityToggleButtons({
102102

103103
<ActionTooltip title="Expand">
104104
<Button
105-
title="Expand"
106105
view="flat-secondary"
107106
onClick={onExpand}
108107
className={b(
109108
{
110109
hidden: !isCollapsed,
110+
type: 'expand',
111111
},
112112
className,
113113
)}

tests/suites/tenant/queryEditor/models/QueryEditor.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,19 +248,21 @@ export class QueryEditor {
248248
}
249249

250250
async collapseResultsControls() {
251-
const collapseButton = this.resultsControls.locator('button[title="Collapse"]');
251+
const collapseButton = this.resultsControls.locator(
252+
'.kv-pane-visibility-button_type_collapse',
253+
);
252254
await collapseButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
253255
await collapseButton.click();
254256
}
255257

256258
async expandResultsControls() {
257-
const expandButton = this.resultsControls.locator('button[title="Expand"]');
259+
const expandButton = this.resultsControls.locator('.kv-pane-visibility-button_type_expand');
258260
await expandButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
259261
await expandButton.click();
260262
}
261263

262264
async isResultsControlsCollapsed() {
263-
const expandButton = this.resultsControls.locator('button[title="Expand"]');
265+
const expandButton = this.resultsControls.locator('.kv-pane-visibility-button_type_expand');
264266
try {
265267
await expandButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
266268
return true;

tests/suites/tenant/summary/ObjectSummary.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,16 @@ export class ObjectSummary {
5050

5151
// Info panel collapse/expand buttons
5252
this.infoCollapseButton = page.locator(
53-
'.ydb-object-summary__info-controls button[title="Collapse"]',
53+
'.ydb-object-summary__info-controls .kv-pane-visibility-button_type_collapse',
5454
);
5555
this.infoExpandButton = page.locator(
56-
'.ydb-object-summary__info-controls button[title="Expand"]',
56+
'.ydb-object-summary__info-controls .kv-pane-visibility-button_type_expand',
5757
);
5858
this.summaryCollapseButton = page.locator(
59-
'.ydb-object-summary__actions button[title="Collapse"]',
59+
'.ydb-object-summary__actions .kv-pane-visibility-button_type_collapse',
6060
);
6161
this.summaryExpandButton = page.locator(
62-
'.ydb-object-summary__actions button[title="Expand"]',
62+
'.ydb-object-summary__actions .kv-pane-visibility-button_type_expand',
6363
);
6464
this.overviewWrapper = page.locator('.ydb-object-summary__overview-wrapper');
6565
}

0 commit comments

Comments
 (0)