Skip to content

Commit dbaa1a4

Browse files
committed
fix: review fixes
1 parent 5ecaf0a commit dbaa1a4

File tree

2 files changed

+22
-26
lines changed

2 files changed

+22
-26
lines changed

src/containers/Operations/columns.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,7 @@ function OperationsActions({operation, database, refreshTable}: OperationsAction
163163

164164
return (
165165
<div className={b('buttons-container')}>
166-
<Tooltip
167-
openDelay={0}
168-
content={i18n('header_forget')}
169-
placement={['right', 'right-end', 'right-start', 'top', 'bottom']}
170-
>
166+
<Tooltip openDelay={0} content={i18n('header_forget')} placement={['left', 'auto']}>
171167
<div>
172168
<ButtonWithConfirmDialog
173169
buttonView="outlined"
@@ -184,11 +180,7 @@ function OperationsActions({operation, database, refreshTable}: OperationsAction
184180
</ButtonWithConfirmDialog>
185181
</div>
186182
</Tooltip>
187-
<Tooltip
188-
openDelay={0}
189-
content={i18n('header_cancel')}
190-
placement={['left', 'left-end', 'left-start', 'top', 'bottom']}
191-
>
183+
<Tooltip openDelay={0} content={i18n('header_cancel')} placement={['right', 'auto']}>
192184
<div>
193185
<ButtonWithConfirmDialog
194186
buttonView="outlined"

src/containers/Tablets/TabletsTable.tsx

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {ArrowRotateLeft} from '@gravity-ui/icons';
22
import type {Column as DataTableColumn} from '@gravity-ui/react-data-table';
3-
import {Icon, Text} from '@gravity-ui/uikit';
3+
import {Icon, Text, Tooltip} from '@gravity-ui/uikit';
44

55
import {ButtonWithConfirmDialog} from '../../components/ButtonWithConfirmDialog/ButtonWithConfirmDialog';
66
import {EntityStatus} from '../../components/EntityStatus/EntityStatus';
@@ -126,21 +126,25 @@ function TabletActions(tablet: TTabletStateInfo) {
126126
}
127127

128128
return (
129-
<ButtonWithConfirmDialog
130-
buttonView="outlined"
131-
buttonTitle={i18n('dialog.kill-header')}
132-
dialogHeader={i18n('dialog.kill-header')}
133-
dialogText={i18n('dialog.kill-text')}
134-
onConfirmAction={() => {
135-
return killTablet({id}).unwrap();
136-
}}
137-
buttonDisabled={isDisabledRestart || !isUserAllowedToMakeChanges}
138-
withPopover
139-
popoverContent={i18n('controls.kill-not-allowed')}
140-
popoverDisabled={isUserAllowedToMakeChanges}
141-
>
142-
<Icon data={ArrowRotateLeft} />
143-
</ButtonWithConfirmDialog>
129+
<Tooltip openDelay={0} content={i18n('dialog.kill-header')} placement={['right', 'auto']}>
130+
<div>
131+
<ButtonWithConfirmDialog
132+
buttonView="outlined"
133+
buttonTitle={i18n('dialog.kill-header')}
134+
dialogHeader={i18n('dialog.kill-header')}
135+
dialogText={i18n('dialog.kill-text')}
136+
onConfirmAction={() => {
137+
return killTablet({id}).unwrap();
138+
}}
139+
buttonDisabled={isDisabledRestart || !isUserAllowedToMakeChanges}
140+
withPopover
141+
popoverContent={i18n('controls.kill-not-allowed')}
142+
popoverDisabled={isUserAllowedToMakeChanges}
143+
>
144+
<Icon data={ArrowRotateLeft} />
145+
</ButtonWithConfirmDialog>
146+
</div>
147+
</Tooltip>
144148
);
145149
}
146150

0 commit comments

Comments
 (0)