fix(Network): correctly pass database in peer role (#2831)

Author: artemmufazalov

src/containers/Nodes/NodesControls/NodesControls.tsx

@@ -57,7 +57,7 @@ export function NodesControls({
         handleUptimeFilterChange,
         handlePeerRoleFilterChange,
         handleGroupByParamChange,
-    } = useNodesPageQueryParams(groupByParams);
+    } = useNodesPageQueryParams(groupByParams, withPeerRoleFilter);
     const {problemFilter, handleProblemFilterChange} = useProblemFilter();
     const isViewerUser = useIsViewerUser();
 

src/containers/Nodes/PaginatedNodes/GroupedNodesComponent.tsx

@@ -103,7 +103,10 @@ export function GroupedNodesComponent({
     selectedColumnsKey,
     groupByParams,
 }: GroupedNodesComponentProps) {
-    const {searchValue, peerRoleFilter, groupByParam} = useNodesPageQueryParams(groupByParams);
+    const {searchValue, peerRoleFilter, groupByParam} = useNodesPageQueryParams(
+        groupByParams,
+        withPeerRoleFilter,
+    );
     const [autoRefreshInterval] = useAutoRefreshInterval();
 
     const {columnsToShow, columnsToSelect, setColumns} = useSelectedColumns(

src/containers/Nodes/PaginatedNodes/NodesComponent.tsx

@@ -37,7 +37,10 @@ export function NodesComponent({
     selectedColumnsKey,
     groupByParams,
 }: NodesComponentProps) {
-    const {searchValue, uptimeFilter, peerRoleFilter} = useNodesPageQueryParams(groupByParams);
+    const {searchValue, uptimeFilter, peerRoleFilter} = useNodesPageQueryParams(
+        groupByParams,
+        withPeerRoleFilter,
+    );
     const {problemFilter} = useProblemFilter();
     const viewerNodesHandlerHasGrouping = useViewerNodesHandlerHasGrouping();
 

src/containers/Nodes/PaginatedNodes/PaginatedNodes.tsx

@@ -33,6 +33,7 @@ export interface PaginatedNodesProps {
 export function PaginatedNodes(props: PaginatedNodesProps) {
     const {uptimeFilter, groupByParam, handleUptimeFilterChange} = useNodesPageQueryParams(
         props.groupByParams,
+        props.withPeerRoleFilter,
     );
 
     const {problemFilter, handleProblemFilterChange} = useProblemFilter();

src/containers/Nodes/PeerRoleFilter/utils.tsx

@@ -18,6 +18,9 @@ export const NODES_PEER_ROLES_TITLES: Record<NodesPeerRole, string> = {
     },
 };
 
-export function parseNodesPeerRoleFilter(paramToParse: unknown): NodesPeerRole | undefined {
-    return NODES_PEER_ROLES.find((peerRoleParam) => peerRoleParam === paramToParse);
+export function parseNodesPeerRoleFilter(
+    paramToParse: unknown,
+    defaultValue?: NodesPeerRole,
+): NodesPeerRole | undefined {
+    return NODES_PEER_ROLES.find((peerRoleParam) => peerRoleParam === paramToParse) ?? defaultValue;
 }

src/containers/Nodes/useNodesPageQueryParams.ts

@@ -9,7 +9,10 @@ import {nodesUptimeFilterValuesSchema} from '../../utils/nodes';
 import {parseNodesPeerRoleFilter} from './PeerRoleFilter/utils';
 import {parseNodesGroupByParam} from './columns/constants';
 
-export function useNodesPageQueryParams(groupByParams: NodesGroupByField[] | undefined) {
+export function useNodesPageQueryParams(
+    groupByParams: NodesGroupByField[] | undefined,
+    withPeerRoleFilter: boolean | undefined,
+) {
     const [queryParams, setQueryParams] = useQueryParams({
         uptimeFilter: StringParam,
         peerRole: StringParam,
@@ -21,9 +24,15 @@ export function useNodesPageQueryParams(groupByParams: NodesGroupByField[] | und
 
     const uptimeFilter = nodesUptimeFilterValuesSchema.parse(queryParams.uptimeFilter);
     const searchValue = queryParams.search ?? '';
-    const peerRoleFilter = isViewerUser
-        ? parseNodesPeerRoleFilter(queryParams.peerRole)
-        : 'database';
+
+    let peerRoleFilter: NodesPeerRole | undefined;
+
+    // Do not add peerRoleFilter on Cluster page Network tab
+    if (withPeerRoleFilter) {
+        peerRoleFilter = isViewerUser
+            ? parseNodesPeerRoleFilter(queryParams.peerRole, 'database')
+            : 'database';
+    }
 
     const systemStateGroupingAvailable = useViewerNodesHandlerHasGroupingBySystemState();
     const groupByParam = parseNodesGroupByParam(