Skip to content

Commit e25efd8

Browse files
committed
fix(Healthcheck): types
1 parent 7594f70 commit e25efd8

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

src/containers/Tenant/Healthcheck/components/HealthcheckView.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ const HealthcheckViewValues: Record<string, CommonIssueType> = {
1212
compute: 'compute',
1313
};
1414

15-
interface HealthcheckViewProps<T extends string = CommonIssueType> {
16-
issuesCount: Record<T, number>;
17-
viewTitles?: Record<T, string>;
18-
sortOrder?: T[];
15+
interface HealthcheckViewProps {
16+
issuesCount: Record<CommonIssueType, number> & Record<string, number>;
17+
viewTitles?: Record<CommonIssueType, string> & Record<string, string>;
18+
sortOrder?: (CommonIssueType | string)[];
1919
}
2020

2121
export function HealthcheckView({

src/containers/Tenant/Healthcheck/shared.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export function countHealthcheckIssuesByType(
4545
return result;
4646
}
4747

48-
export type GetHealthcheckViewTitles<T extends string> = () => Record<T, string>;
48+
export type GetHealthcheckViewTitles = () => Record<CommonIssueType, string> &
49+
Record<string, string>;
4950

50-
export type GetHealthcheckViewsOrder<T> = () => T[];
51+
export type GetHealthcheckViewsOrder = () => (CommonIssueType | string)[];

src/uiFactory/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ export interface UIFactory {
2929
getClusterLinks?: GetClusterLinks;
3030

3131
healthcheck: {
32-
getHealthckechViewTitles: GetHealthcheckViewTitles<CommonIssueType>;
33-
getHealthcheckViewsOrder: GetHealthcheckViewsOrder<CommonIssueType>;
32+
getHealthckechViewTitles: GetHealthcheckViewTitles;
33+
getHealthcheckViewsOrder: GetHealthcheckViewsOrder;
3434
};
3535
countHealthcheckIssuesByType: (
3636
issueTrees: IssuesTree[],

0 commit comments

Comments
 (0)