fix: review fixes

Author: astandrik

src/components/ProgressWrapper/SingleProgress.tsx

@@ -38,7 +38,7 @@ export function SingleProgress({
     }, [formatValues, value, capacity]);
 
     const displayText = React.useMemo(() => {
-        return formatProgressText(valueText, capacityText, numericCapacity, i18n);
+        return formatProgressText(valueText, capacityText, numericCapacity);
     }, [valueText, capacityText, numericCapacity]);
 
     return (

src/components/ProgressWrapper/StackProgress.tsx

@@ -46,12 +46,7 @@ export function StackProgress({
     }, [formatValues, totalValue, numericTotalCapacity]);
 
     const displayText = React.useMemo(() => {
-        return formatProgressText(
-            totalValueText,
-            totalCapacityText,
-            numericTotalCapacity || 0,
-            i18n,
-        );
+        return formatProgressText(totalValueText, totalCapacityText, numericTotalCapacity || 0);
     }, [totalValueText, totalCapacityText, numericTotalCapacity]);
 
     return (

src/components/ProgressWrapper/progressUtils.ts

@@ -1,6 +1,8 @@
 import type {FormatProgressViewerValues} from '../../utils/progress';
 import {isNumeric, safeParseNumber} from '../../utils/utils';
 
+import i18n from './i18n';
+
 // Constants that were previously in TenantStorage/constants
 export const DEFAULT_PROGRESS_WIDTH = 400;
 export const MAX_PERCENTAGE = 100;
@@ -31,7 +33,6 @@ export function formatProgressText(
     valueText: string | number | undefined,
     capacityText: string | number | undefined,
     numericCapacity: number,
-    i18n: any,
 ): string {
     if (numericCapacity <= 0) {
         return String(valueText);

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/MemorySegmentItem.tsx

@@ -18,6 +18,10 @@ export function MemorySegmentItem({segment}: MemorySegmentItemProps) {
 
     const valueText = formatSegmentValue(segment.value, segment.capacity);
 
+    const progressStyle: React.CSSProperties & Record<string, string> = {
+        '--g-progress-filled-background-color': segmentColor,
+    };
+
     return (
         <div className={b('segment-row')}>
             <div className={b('segment-indicator')} style={{backgroundColor: segmentColor}} />
@@ -31,13 +35,7 @@ export function MemorySegmentItem({segment}: MemorySegmentItemProps) {
                 >
                     <Flex alignItems="center" gap="3">
                         <div className={b('segment-progress')}>
-                            <div
-                                style={
-                                    {
-                                        '--g-progress-filled-background-color': segmentColor,
-                                    } as React.CSSProperties
-                                }
-                            >
+                            <div style={progressStyle}>
                                 <Progress
                                     value={
                                         segment.capacity

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/TenantMemory.scss

@@ -5,6 +5,7 @@
         flex-shrink: 0;
 
         min-width: 84px;
+        margin-top: var(--g-spacing-2);
 
         text-align: right;
         white-space: nowrap;

src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/TenantMemory.tsx

@@ -46,10 +46,12 @@ export function TenantMemory({
                                     memoryUsed={memoryUsed}
                                     memoryLimit={memoryLimit}
                                 />
-                                <div className={b('value-text')} style={{marginTop: '8px'}}>
-                                    {formatStorageValuesToGb(Number(memoryUsed))[0]} of{' '}
-                                    {formatStorageValuesToGb(Number(memoryLimit))[0]}
-                                </div>
+                                {memoryUsed && memoryLimit && (
+                                    <div className={b('value-text')}>
+                                        {formatStorageValuesToGb(Number(memoryUsed))[0]} of{' '}
+                                        {formatStorageValuesToGb(Number(memoryLimit))[0]}
+                                    </div>
+                                )}
                             </div>
                         ),
                     },