fix: do not retry requests by user (#1059)

Author: artemmufazalov

src/services/api.ts

@@ -18,14 +18,7 @@ import type {TNetInfo} from '../types/api/netInfo';
 import type {TNodesInfo} from '../types/api/nodes';
 import type {TEvNodesInfo} from '../types/api/nodesList';
 import type {TEvPDiskStateResponse, TPDiskInfoResponse} from '../types/api/pdisk';
-import type {
-    Actions,
-    ErrorResponse,
-    ExplainActions,
-    ExplainResponse,
-    QueryAPIResponse,
-    Schemas,
-} from '../types/api/query';
+import type {Actions, ErrorResponse, QueryAPIResponse, Schemas} from '../types/api/query';
 import type {JsonRenderRequestParams, JsonRenderResponse} from '../types/api/render';
 import type {RestartPDiskResponse} from '../types/api/restartPDisk';
 import type {TEvDescribeSchemeResult} from '../types/api/schema';
@@ -53,14 +46,17 @@ import {settingsManager} from './settings';
 type AxiosOptions = {
     concurrentId?: string;
     signal?: AbortSignal;
+    withRetries?: boolean;
 };
 
 export class YdbEmbeddedAPI extends AxiosWrapper {
+    DEFAULT_RETRIES_COUNT = 3;
+
     constructor(options?: AxiosWrapperOptions) {
         super(options);
 
         axiosRetry(this._axios, {
-            retries: 3,
+            retries: this.DEFAULT_RETRIES_COUNT,
             retryDelay: axiosRetry.exponentialDelay,
         });
 
@@ -442,7 +438,7 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
             schema?: Schema;
             syntax?: QuerySyntax;
         },
-        {concurrentId, signal}: AxiosOptions = {},
+        {concurrentId, signal, withRetries}: AxiosOptions = {},
     ) {
         // Time difference to ensure that timeout from ui will be shown rather than backend error
         const uiTimeout = 9 * 60 * 1000;
@@ -468,38 +464,11 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
             {
                 concurrentId,
                 timeout: uiTimeout,
-                requestConfig: {signal},
-            },
-        );
-    }
-    getExplainQuery<Action extends ExplainActions>(
-        query: string,
-        database: string,
-        action: Action,
-        syntax?: QuerySyntax,
-    ) {
-        return this.post<ExplainResponse<Action> | ErrorResponse>(
-            this.getPath('/viewer/json/query'),
-            {
-                query,
-                database,
-                action: action || 'explain',
-                syntax,
-                timeout: 600000,
-            },
-            {},
-        );
-    }
-    getExplainQueryAst(query: string, database: string) {
-        return this.post<ExplainResponse<'explain-ast'>>(
-            this.getPath('/viewer/json/query'),
-            {
-                query,
-                database,
-                action: 'explain-ast',
-                timeout: 600000,
+                requestConfig: {
+                    signal,
+                    'axios-retry': {retries: withRetries ? this.DEFAULT_RETRIES_COUNT : 0},
+                },
             },
-            {},
         );
     }
     getHotKeys(
@@ -562,6 +531,7 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
                     // Automatic headers may not suit
                     Accept: 'application/json',
                 },
+                requestConfig: {'axios-retry': {retries: 0}},
             },
         );
     }
@@ -580,22 +550,29 @@ export class YdbEmbeddedAPI extends AxiosWrapper {
                 headers: {
                     'Content-Type': 'application/x-www-form-urlencoded; charset=UTF-8',
                 },
+                requestConfig: {'axios-retry': {retries: 0}},
             },
         );
     }
     killTablet(id?: string) {
-        return this.get<string>(this.getPath(`/tablets?KillTabletID=${id}`), {});
+        return this.get<string>(
+            this.getPath(`/tablets?KillTabletID=${id}`),
+            {},
+            {requestConfig: {'axios-retry': {retries: 0}}},
+        );
     }
     stopTablet(id?: string, hiveId?: string) {
         return this.get<string>(
             this.getPath(`/tablets/app?TabletID=${hiveId}&page=StopTablet&tablet=${id}`),
             {},
+            {requestConfig: {'axios-retry': {retries: 0}}},
         );
     }
     resumeTablet(id?: string, hiveId?: string) {
         return this.get<string>(
             this.getPath(`/tablets/app?TabletID=${hiveId}&page=ResumeTablet&tablet=${id}`),
             {},
+            {requestConfig: {'axios-retry': {retries: 0}}},
         );
     }
     getTabletDescribe(tenantId: TDomainKey, {concurrentId, signal}: AxiosOptions = {}) {

src/store/reducers/executeTopQueries/executeTopQueries.ts

@@ -62,7 +62,7 @@ export const topQueriesApi = api.injectEndpoints({
                             database,
                             action: 'execute-scan',
                         },
-                        {signal},
+                        {signal, withRetries: true},
                     );
 
                     if (isQueryErrorResponse(response)) {

src/store/reducers/explainQuery/explainQuery.ts

@@ -25,12 +25,12 @@ export const explainQueryApi = api.injectEndpoints({
                 }
 
                 try {
-                    const response = await window.api.getExplainQuery(
+                    const response = await window.api.sendQuery({
                         query,
                         database,
                         action,
                         syntax,
-                    );
+                    });
 
                     if (isQueryErrorResponse(response)) {
                         return {error: response};

src/store/reducers/preview.ts

@@ -16,7 +16,7 @@ export const previewApi = api.injectEndpoints({
                 try {
                     const response = await window.api.sendQuery(
                         {schema: 'modern', query, database, action},
-                        {signal},
+                        {signal, withRetries: true},
                     );
 
                     if (isQueryErrorResponse(response)) {

src/store/reducers/shardsWorkload/shardsWorkload.ts

@@ -148,6 +148,7 @@ export const shardApi = api.injectEndpoints({
                         },
                         {
                             signal,
+                            withRetries: true,
                         },
                     );
 

src/store/reducers/tenantOverview/executeTopTables/executeTopTables.ts

@@ -25,7 +25,7 @@ export const topTablesApi = api.injectEndpoints({
                             database: path,
                             action: 'execute-scan',
                         },
-                        {signal},
+                        {signal, withRetries: true},
                     );
 
                     if (isQueryErrorResponse(response)) {

src/store/reducers/tenantOverview/topShards/tenantOverviewTopShards.ts

@@ -33,7 +33,7 @@ export const topShardsApi = api.injectEndpoints({
                             database,
                             action: queryAction,
                         },
-                        {signal},
+                        {signal, withRetries: true},
                     );
 
                     if (isQueryErrorResponse(response)) {

src/store/reducers/viewSchema/viewSchema.ts

@@ -10,12 +10,15 @@ export const viewSchemaApi = api.injectEndpoints({
         getViewSchema: build.query({
             queryFn: async ({database, path}: {database: string; path: string}) => {
                 try {
-                    const response = await window.api.sendQuery({
-                        schema: 'modern',
-                        query: createViewSchemaQuery(path),
-                        database,
-                        action: 'execute-scan',
-                    });
+                    const response = await window.api.sendQuery(
+                        {
+                            schema: 'modern',
+                            query: createViewSchemaQuery(path),
+                            database,
+                            action: 'execute-scan',
+                        },
+                        {withRetries: true},
+                    );
 
                     if (isQueryErrorResponse(response)) {
                         return {error: response};