feat(TableColumnSelector): apply settings immediatelly (#2907)

Author: Raubzeug

package-lock.json

@@ -24,7 +24,7 @@
     "@gravity-ui/paranoid": "^3.0.0",
     "@gravity-ui/react-data-table": "^2.2.1",
     "@gravity-ui/table": "^1.10.1",
-    "@gravity-ui/uikit": "^7.22.0",
+    "@gravity-ui/uikit": "^7.23.0",
     "@gravity-ui/unipika": "^5.2.1",
     "@gravity-ui/websql-autocomplete": "^13.7.0",
     "@hookform/resolvers": "^3.10.0",

package.json

@@ -29,5 +29,5 @@ export function TableColumnSetup(props: TableColumnSetupProps) {
         );
     };
 
-    return <TableColumnSetupUikit {...props} renderSwitcher={renderSwitcher} />;
+    return <TableColumnSetupUikit {...props} renderSwitcher={renderSwitcher} hideApplyButton />;
 }

src/components/TableColumnSetup/TableColumnSetup.tsx

@@ -33,7 +33,6 @@ test.describe('Bridge mode - Nodes table', () => {
         const table = new ClusterNodesTable(page);
         await table.getControls().openColumnSetup();
         await table.getControls().setColumnChecked('PileName');
-        await table.getControls().applyColumnVisibility();
         await table.waitForTableToLoad();
         const headers = await table.getHeaders();
         expect(headers.join(' ')).toContain('Pile Name');
@@ -49,7 +48,6 @@ test.describe('Bridge mode - Storage nodes', () => {
         const table = new ClusterStorageTable(page);
         await table.getControls().openColumnSetup();
         await table.getControls().setColumnChecked('PileName');
-        await table.getControls().applyColumnVisibility();
         await table.waitForTableToLoad();
         const headers = await table.getHeaders();
         expect(headers.join(' ')).toContain('Pile Name');
@@ -75,7 +73,6 @@ test.describe('Bridge mode - Storage groups', () => {
         const table = new ClusterStorageTable(page);
         await table.getControls().openColumnSetup();
         await table.getControls().setColumnChecked('PileName');
-        await table.getControls().applyColumnVisibility();
         await table.waitForTableToLoad();
         const headers = await table.getHeaders();
         expect(headers.join(' ')).toContain('Pile Name');

tests/suites/bridge/bridge.test.ts

@@ -18,7 +18,6 @@ test.describe('Memory Viewer Widget', () => {
             const controls = paginatedTable.getControls();
             await controls.openColumnSetup();
             await controls.setColumnChecked('Memory');
-            await controls.applyColumnVisibility();
         }
         await memoryViewer.waitForVisible();
     });

tests/suites/memoryViewer/memoryViewer.test.ts

@@ -84,12 +84,6 @@ export class TableControls {
         }
     }
 
-    async applyColumnVisibility() {
-        const applyButton = this.columnSetupPopup.locator('button:has-text("Apply")');
-        await applyButton.click();
-        await this.columnSetupPopup.waitFor({state: 'hidden'});
-    }
-
     async getVisibleColumnsCount(): Promise<string> {
         const statusText = await this.columnSetupButton
             .locator('.g-table-column-setup__status')

tests/suites/paginatedTable/paginatedTable.ts

@@ -28,7 +28,6 @@ test.describe('Diagnostics Nodes tab', async () => {
         const controls = paginatedTable.getControls();
         await controls.openColumnSetup();
         await controls.setColumnChecked('Memory');
-        await controls.applyColumnVisibility();
 
         // Check memory viewer is present and visible
         await diagnostics.memoryViewer.waitForVisible();