fix: skipped tests

Author: Anton Standrik

.github/workflows/ci.yml

@@ -241,6 +241,15 @@ jobs:
             fi
           }
 
+          # Get skipped tests first from test results
+          if [ -f "playwright-artifacts/test-results.json" ]; then
+            while IFS= read -r test; do
+              if [[ -n "$test" ]]; then
+                skipped_tests+=("$test")
+              fi
+            done < <(jq -r '.suites[].specs[] | select(.ok == false and .skipped == true) | .title' playwright-artifacts/test-results.json)
+          fi
+
           # Get list of changed test files
           for file in $(git diff --name-only main...HEAD | grep -E '^tests/suites/.*\.(spec|test)\.(ts|tsx|js|jsx)$'); do
             # Get test names from both versions
@@ -258,18 +267,14 @@ jobs:
 
             while IFS= read -r test; do
               if [[ -n "$test" ]]; then
-                if ! echo "$current_tests" | grep -Fxq "$test"; then
+                # Only mark as deleted if it's not in current tests AND not in skipped tests
+                if ! echo "$current_tests" | grep -Fxq "$test" && ! printf '%s\n' "${skipped_tests[@]}" | grep -Fxq "$test"; then
                   deleted_tests+=("$test")
                 fi
               fi
             done <<< "$base_tests"
           done
 
-          # Get skipped tests from test results
-          if [ -f "playwright-artifacts/test-results.json" ]; then
-            skipped_tests=($(jq -r '.suites[].specs[] | select(.ok == false and .skipped == true) | .title' playwright-artifacts/test-results.json))
-          fi
-
           # Create JSON output
           echo "added_tests=$(IFS=,; echo "${added_tests[*]}")" >> $GITHUB_OUTPUT
           echo "deleted_tests=$(IFS=,; echo "${deleted_tests[*]}")" >> $GITHUB_OUTPUT
@@ -345,10 +350,13 @@ jobs:
             |:-----:|:------:|:------:|:-----:|:-------:|
             | ${testResults.total} | ${testResults.passed} | ${testResults.failed} | ${testResults.flaky} | ${changesText} |
 
-            ### Test Changes Details
+            <details>
+            <summary>📋 Test Changes Details</summary>
+
             ${addedCount > 0 ? `\n✨ **Added Tests (${addedCount}):**\n${addedTests.map(t => `- ${t}`).join('\n')}` : ''}
             ${deletedCount > 0 ? `\n🗑️ **Deleted Tests (${deletedCount}):**\n${deletedTests.map(t => `- ${t}`).join('\n')}` : ''}
             ${skippedCount > 0 ? `\n⏭️ **Skipped Tests (${skippedCount}):**\n${skippedTests.map(t => `- ${t}`).join('\n')}` : ''}
+            </details>
 
             ### Bundle Size: ${bundleStatus}
             Current: ${formatSize(currentSize)} | Main: ${formatSize(mainSize)}

tests/suites/tenant/queryEditor/models/QueryEditor.ts

@@ -109,13 +109,11 @@ export class QueryEditor {
     async clickRunButton() {
         await this.runButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
         await this.runButton.click();
-        await this.page.waitForTimeout(1000);
     }
 
     async clickExplainButton() {
         await this.explainButton.waitFor({state: 'visible', timeout: VISIBILITY_TIMEOUT});
         await this.explainButton.click();
-        await this.page.waitForTimeout(1000);
     }
 
     async getExplainResult(type: ExplainResultType) {

tests/suites/tenant/queryEditor/queryTemplates.test.ts

@@ -61,6 +61,7 @@ test.describe('Query Templates', () => {
 
         // Try to run the query
         await queryEditor.clickRunButton();
+        await page.waitForTimeout(500);
 
         try {
             // Wait for either Completed or Failed status