-
Notifications
You must be signed in to change notification settings - Fork 17
chore: disable claude for drafts #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@claude where are you |
|
Claude finished @astandrik's task —— View job I'm here! 👋 I see you're working on disabling Claude for draft PRs. The changes in |
|
@claude I moved this pr from draft to ready for review and it should have triggered claude code review but it didnt - whats the problem? |
|
Claude finished @astandrik's task —— View job I found the issue! The workflow didn't trigger because of a condition in the GitHub Actions workflow configuration. Todo List:
The ProblemLooking at the workflow file, I can see that the (github.event.pull_request.author_association == 'OWNER' ||
github.event.pull_request.author_association == 'MEMBER' ||
github.event.pull_request.author_association == 'COLLABORATOR')Your author association might not match any of these values. In GitHub, author associations can include:
If you're a regular contributor but not an organization member, owner, or collaborator, your association would be SolutionTo fix this, you need to add (github.event.pull_request.author_association == 'OWNER' ||
github.event.pull_request.author_association == 'MEMBER' ||
github.event.pull_request.author_association == 'COLLABORATOR' ||
github.event.pull_request.author_association == 'CONTRIBUTOR')This should allow the workflow to trigger for regular contributors when PRs are moved from draft to ready for review. |
|
@claude how to check who am I |
|
Claude finished @astandrik's task —— View job Claude finished @astandrik's task —— View job To check your GitHub author association for this repository, you can use these methods: 1. Using GitHub API (Easiest)Check this URL in your browser: Look for the 2. Using GitHub CLIIf you have gh api repos/ydb-platform/ydb-embedded-ui/pulls/2643 --jq '.author_association'3. Check via GitHub Actions LogsWhen a workflow runs, you can see the author association in the workflow logs under the context dump (if the workflow includes Author Association Types:
Based on your contributions to this repository, you're likely a CONTRIBUTOR, which isn't currently included in the workflow's author association check (lines 22-24). That's why the workflow didn't trigger when you moved the PR from draft to ready. |
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 85.35 MB | Main: 85.35 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information