Skip to content

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Jul 31, 2025

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 4 2
Test Changes Summary ⏭️2

⏭️ Skipped Tests (2)

  1. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  2. Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: ✅

Current: 85.35 MB | Main: 85.35 MB
Diff: 0.00 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik marked this pull request as ready for review July 31, 2025 13:34
artemmufazalov
artemmufazalov previously approved these changes Jul 31, 2025
@astandrik astandrik marked this pull request as draft July 31, 2025 13:48
@astandrik astandrik marked this pull request as ready for review July 31, 2025 15:47
@astandrik
Copy link
Collaborator Author

@claude where are you

@astandrik
Copy link
Collaborator Author

@claude

@claude
Copy link

claude bot commented Jul 31, 2025

Claude finished @astandrik's task —— View job


I'm here! 👋

I see you're working on disabling Claude for draft PRs. The changes in .github/workflows/claude-code-review.yml look straightforward. Is there something specific you'd like me to help with regarding this PR?


@astandrik astandrik marked this pull request as draft July 31, 2025 16:29
@astandrik astandrik marked this pull request as ready for review July 31, 2025 16:32
@astandrik
Copy link
Collaborator Author

@claude I moved this pr from draft to ready for review and it should have triggered claude code review but it didnt - whats the problem?

@claude
Copy link

claude bot commented Jul 31, 2025

Claude finished @astandrik's task —— View job


I found the issue! The workflow didn't trigger because of a condition in the GitHub Actions workflow configuration.

Todo List:

  • Read the workflow file to understand the current changes
  • Analyze why the workflow didn't trigger
  • Provide explanation and solution

The Problem

Looking at the workflow file, I can see that the ready_for_review event was added on line 5, which is correct. However, the issue is with the author association check on lines 22-24:

(github.event.pull_request.author_association == 'OWNER' ||
 github.event.pull_request.author_association == 'MEMBER' ||
 github.event.pull_request.author_association == 'COLLABORATOR')

Your author association might not match any of these values. In GitHub, author associations can include:

  • OWNER
  • MEMBER
  • COLLABORATOR
  • CONTRIBUTOR
  • FIRST_TIME_CONTRIBUTOR
  • NONE

If you're a regular contributor but not an organization member, owner, or collaborator, your association would be CONTRIBUTOR, which isn't included in the current condition.

Solution

To fix this, you need to add CONTRIBUTOR to the author association check. However, I cannot modify workflow files due to GitHub App permissions. You'll need to update line 22-24 to include:

(github.event.pull_request.author_association == 'OWNER' ||
 github.event.pull_request.author_association == 'MEMBER' ||
 github.event.pull_request.author_association == 'COLLABORATOR' ||
 github.event.pull_request.author_association == 'CONTRIBUTOR')

This should allow the workflow to trigger for regular contributors when PRs are moved from draft to ready for review.

@astandrik
Copy link
Collaborator Author

@claude how to check who am I

@astandrik astandrik closed this Jul 31, 2025
@claude
Copy link

claude bot commented Jul 31, 2025

Claude finished @astandrik's task —— View job


Claude finished @astandrik's task —— View job


To check your GitHub author association for this repository, you can use these methods:

1. Using GitHub API (Easiest)

Check this URL in your browser:

https://api.github.com/repos/ydb-platform/ydb-embedded-ui/pulls/2643

Look for the "author_association" field under the pull request data.

2. Using GitHub CLI

If you have gh installed:

gh api repos/ydb-platform/ydb-embedded-ui/pulls/2643 --jq '.author_association'

3. Check via GitHub Actions Logs

When a workflow runs, you can see the author association in the workflow logs under the context dump (if the workflow includes github.event.pull_request.author_association in its output).

Author Association Types:

  • OWNER: Repository/organization owner
  • MEMBER: Organization member
  • COLLABORATOR: Has direct write access to the repository
  • CONTRIBUTOR: Has previously committed to the repository
  • FIRST_TIME_CONTRIBUTOR: First contribution to the repo
  • NONE: No association

Based on your contributions to this repository, you're likely a CONTRIBUTOR, which isn't currently included in the workflow's author association check (lines 22-24). That's why the workflow didn't trigger when you moved the PR from draft to ready.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants