Skip to content

fix: show structure tab and PDisk/VDisk if disk's new API is absent #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix: show structure tab and PDisk/VDisk if disk's new API is absent #1338

merged 3 commits into from
Sep 24, 2024

Conversation

@ValeraS
Copy link
Collaborator

@ValeraS ValeraS commented Sep 24, 2024 •
edited by github-actions bot
Loading

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
124 124 0 0 0

Bundle Size: 🔺

Current: 79.05 MB | Main: 79.00 MB
Diff: +0.06 MB (0.07%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

artemmufazalov
artemmufazalov requested changes Sep 24, 2024
View reviewed changes
@ValeraS ValeraS changed the title fix(Node): show structure tab if new disk pages is not available fix(Node): show structure tab and PDisk/VDisk pages if new disk API is not available Sep 24, 2024
@ValeraS ValeraS changed the title fix(Node): show structure tab and PDisk/VDisk pages if new disk API is not available fix: show structure tab and PDisk/VDisk if disk's new API is absent Sep 24, 2024
@artemmufazalov
Copy link
Member

artemmufazalov commented Sep 24, 2024

It's better to hide Disk distribution. There is data about log in viewer/pdiskinfo, but no data about VDisks. So you won't have an empty distribution, you will have distribution with empty slots and log - it's not correct.

The same PDisk with different endpoints:
pdisk/info
Screenshot 2024-09-24 at 18 58 38

viewer/pdiskinfo
Screenshot 2024-09-24 at 18 58 49

artemmufazalov
artemmufazalov requested changes Sep 24, 2024
View reviewed changes
@ValeraS
Copy link
Collaborator Author

ValeraS commented Sep 24, 2024

It's better to hide Disk distribution. There is data about log in viewer/pdiskinfo, but no data about VDisks. So you won't have an empty distribution, you will have distribution with empty slots and log - it's not correct.

The same PDisk with different endpoints: pdisk/info

Seems ExpectedSlotCount is a new field. Let's simply remove it from results of viewer/pdiskinfo.

@artemmufazalov
Copy link
Member

artemmufazalov commented Sep 24, 2024

Seems ExpectedSlotCount is a new field. Let's simply remove it from results of viewer/pdiskinfo.

It's wrong approach, this field is used to display slots statistics in PdiskInfo

@ValeraS
Copy link
Collaborator Author

ValeraS commented Sep 24, 2024

Seems ExpectedSlotCount is a new field. Let's simply remove it from results of viewer/pdiskinfo.

It's wrong approach, this field is used to display slots statistics in PdiskInfo

Is this field present in viewer/pdiskinfo in backend versions before the disk's new api?

@ValeraS ValeraS added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 6213ed7 Sep 24, 2024
6 checks passed
@ValeraS ValeraS deleted the fix/structure-tab branch September 24, 2024 19:06
@ydb-platform-bot ydb-platform-bot mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ValeraS @artemmufazalov